-
Notifications
You must be signed in to change notification settings - Fork 260
Calculate proof context efficiently #801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
michaelsutton
merged 30 commits into
kaspanet:master
from
coderofstuff:minimize-proof-reiteration
Jan 14, 2026
Merged
Calculate proof context efficiently #801
michaelsutton
merged 30 commits into
kaspanet:master
from
coderofstuff:minimize-proof-reiteration
Jan 14, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7b53396 to
306cef1
Compare
Do this by ensuring that the level_block_at_depth is indeed of sufficient depth (via discrete block counts)
Make a single outer pass to fill the level relations store. When a potentially deep enough root (both in discrete count and blue depth) is found, use it as a root and fill the GD store. This process will minimize the number of retries per level.
521789e to
a0135af
Compare
…less than 2M blues means we have reds and thus require future size increase)
…cs blue score does not count the tip so it cancels...)
…elected_parent_header_at_level and reusable reachable_parents_at_level
freshair18
reviewed
Jan 13, 2026
freshair18
reviewed
Jan 13, 2026
freshair18
reviewed
Jan 13, 2026
b93589f to
ffaee97
Compare
michaelsutton
previously approved these changes
Jan 13, 2026
michaelsutton
approved these changes
Jan 13, 2026
coderofstuff
commented
Jan 13, 2026
Collaborator
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed the latest changes. LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make a single outer pass to fill the level relations store. When a potentially deep enough root (both in discrete count and blue depth) is found, use it as a root and fill the GD store.
This process will minimize the number of retries per level.
This solves the issue where producing the proof for higher levels can go upwards of 100 tries. With this change, only exactly one iteration is needed.