This repository has been archived by the owner on Jun 28, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 196
CCv0: improve debugability of SEV/SNP tests #5710
Open
wainersm
wants to merge
5
commits into
kata-containers:CCv0
Choose a base branch
from
wainersm:tests_amd_improvements
base: CCv0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SEV and SNP tests sometimes fail on CI and it is hard to determine what went wrong because they don't print debug messages. This changed the tests so that they behave like many others: print the system's logs since the test's begin time. Fixes kata-containers#5708 Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
The setup() function of SEV and SNP tests execute some clean up routines to get rid of resources left by the previous test. In reality the good practice is to have the test remove its used resources on teardown. Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
Print the running pods description as well. Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
/test-snp |
The snp fail:
|
stevenhorsman
approved these changes
Jul 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @wainersm!
Print the containerd journal since the start of the test. Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
katacontainersbot
added
size/tiny
Smallest and simplest task
and removed
size/small
Small and simple task
labels
Jul 13, 2023
Added the do-not-merge label because we will use this PR to debug the problem. |
/test-snp |
Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
katacontainersbot
added
size/medium
Average sized task
and removed
size/tiny
Smallest and simplest task
labels
Jul 13, 2023
/test-snp |
/test-snp |
We might need to adjust the debug level of containerd to get the really juicy messages. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's print debug information on the SEV/SNP tests as currently we are left clueless about some fails.
Fixes #5708