This repository has been archived by the owner on Jun 28, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 196
[DEBUG] test sharing image on the host #5776
Draft
ChengyuZhu6
wants to merge
11
commits into
kata-containers:CCv0
Choose a base branch
from
ChengyuZhu6:sharing
base: CCv0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And let's hope for the buest. :-) Signed-off-by: Fabiano Fidêncio <[email protected]>
nydus-snapshotter / nydusd are required for the CoCo effort. Signed-off-by: ChengyuZhu6 <[email protected]>
Ensure nydus is setup to be used by containerd as part of our tests. Signed-off-by: Fabiano Fidêncio <[email protected]> Signed-off-by: ChengyuZhu6 <[email protected]>
Signed-off-by: Fabiano Fidêncio <[email protected]>
Signed-off-by: Fabiano Fidêncio <[email protected]>
The reason for that being: ``` The test case 5 failed due to a specific behavior when using containerd and the snapshotter to download images. Containerd needs to fetch both the manifest and configuration of the image. In this case, both images`quay.io/kata-containers/confidential-containers:signed` and `quay.io/kata-containers/confidential-containers:unsigned` have the same IDs (sha256). Consequently, test case 4 downloaded image `quay.io/kata-containers/confidential-containers:signed`. So, in test case 5, when containerd detected that the image ID already existed, it used the manifest and image name from `quay.io/kata-containers/confidential-containers:signed` and passed it to kata instead of `quay.io/kata-containers/confidential-containers:unsigned`, resulting in the use of image `quay.io/kata-containers/confidential-containers:signed`. This explains the error in test case 5. As a temporary measure, deleting the image before running each test case should address this. ``` from: https://cloud-native.slack.com/archives/C039JSH0807/p1695618313572309?thread_ts=1695591000.697989&cid=C039JSH0807 Signed-off-by: Fabiano Fidêncio <[email protected]>
Update image pull tests to provide registry creds on the host for kubernetes and nydus snapshotter to use Co-authored-by: ChengyuZhu6 <[email protected]> Signed-off-by: stevenhorsman <[email protected]>
Signed-off-by: stevenhorsman <[email protected]>
Signed-off-by: stevenhorsman <[email protected]>
/fidencio-test |
ChengyuZhu6
force-pushed
the
sharing
branch
from
September 27, 2023 01:33
0edf969
to
627d14d
Compare
/fidencio-test |
ChengyuZhu6
force-pushed
the
sharing
branch
from
September 27, 2023 03:25
627d14d
to
1c39166
Compare
/fidencio-test |
ChengyuZhu6
force-pushed
the
sharing
branch
from
September 27, 2023 05:24
1c39166
to
ef9e00e
Compare
/fidencio-test |
Signed-off-by: ChengyuZhu6 <[email protected]>
ChengyuZhu6
force-pushed
the
sharing
branch
from
September 27, 2023 08:19
ef9e00e
to
bbdb8cc
Compare
/fidencio-test |
1 similar comment
/fidencio-test |
ChengyuZhu6
force-pushed
the
sharing
branch
from
September 27, 2023 14:13
db198a5
to
54247f4
Compare
/fidencio-test |
Depends-on: github.com/kata-containers/kata-containers#8076 Signed-off-by: ChengyuZhu6 <[email protected]>
ChengyuZhu6
force-pushed
the
sharing
branch
from
September 27, 2023 15:49
54247f4
to
b6f8c68
Compare
/fidencio-test |
3 similar comments
/fidencio-test |
/fidencio-test |
/fidencio-test |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.