This repository has been archived by the owner on Jul 20, 2023. It is now read-only.
fix(fl-operator): reconnect on reconcile to handle failures with envoy #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In early cluster stage, envoy doesn't yet work as expected and needs a new gRPC connection once it does. This causes a problem with this controller as it caches the (falsy) connection once a first one is established. To fix this, we create a new connection every time the reconcile loop is run.
nfnt
force-pushed
the
jan/fix-falsy-grpc-connection
branch
from
73a21c4
to
376e8df
Compare
nfnt
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In early cluster stage, envoy doesn't yet work as expected and needs a new gRPC connection once it does. This causes a problem with this controller as it caches the (falsy) connection once a first one is established. To fix this, we create a new connection every time the reconcile loop is run.