Skip to content

Use correct "insert ignore" syntax for Sqlite. #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use correct "insert ignore" syntax for Sqlite. #788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pypika/dialects.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -874,6 +874,8 @@ def __init__(self, **kwargs: Any) -> None:
super().__init__(dialect=Dialects.SQLLITE, wrapper_cls=SQLLiteValueWrapper, **kwargs)
self._insert_or_replace = False

_ignore_syntax = "OR IGNORE "

@builder
def insert_or_replace(self, *terms: Any) -> "SQLLiteQueryBuilder":
self._apply_terms(*terms)
Expand Down
4 changes: 3 additions & 1 deletion pypika/queries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1407,10 +1407,12 @@ def _select_sql(self, **kwargs: Any) -> str:
select=",".join(term.get_sql(with_alias=True, subquery=True, **kwargs) for term in self._selects),
)

_ignore_syntax = "IGNORE "

def _insert_sql(self, **kwargs: Any) -> str:
return "INSERT {ignore}INTO {table}".format(
table=self._insert_table.get_sql(**kwargs),
ignore="IGNORE " if self._ignore else "",
ignore=self._ignore_syntax if self._ignore else "",
)

def _replace_sql(self, **kwargs: Any) -> str:
Expand Down