refactor: restructure design docs and clean up provenance#121
Merged
davidfarah2003 merged 6 commits intomainfrom Apr 1, 2026
Merged
refactor: restructure design docs and clean up provenance#121davidfarah2003 merged 6 commits intomainfrom
davidfarah2003 merged 6 commits intomainfrom
Conversation
…hree - Split ACE_DESIGN.md into ACE_ARCHITECTURE.md (concepts), ACE_REFERENCE.md (code examples), and ACE_DECISIONS.md (rejected alternatives) - Merged PYDANTIC_AI_MIGRATION.md content into the new docs - Moved all design docs into docs/design/ - Updated references in CLAUDE.md, AGENTS.md, README.md
- Remove TraceReference and trace traversal engine (~250 lines) - Slim InsightSource to pure identity: 8 fields (was 14) - Remove tagging system (helpful/harmful/neutral counters, TagStep, tag_skill) - Consolidate ace/insight_source.py into ace/steps/attach_insight_sources.py - Replace fuzzy batch matching with deterministic matching - Fix Skillbook.to_dict() to use InsightSource.to_dict() (sparse output) - Omit embedding:null from serialization - Add thread safety to source_map/summary/filter - Document provider SDK requirements in pydantic_ai.py and migration doc
…sightSource The hosted frontend needs these fields to highlight error locations in the trace viewer. They come from the Reflector's analysis and are carried through by AttachInsightSourcesStep.
Skill no longer has tag counter fields. Use getattr with None default in MCP handler to avoid AttributeError.
TagStep is now a pass-through since Skill no longer has tag counters. Add type annotation for limited_skills in MCP handler.
Skill no longer has helpful/harmful/neutral fields, so TagStep had nothing to do. Remove the step, its file, and all references from docs, examples, and tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ACE_DESIGN.mdinto three focused docs:ACE_ARCHITECTURE.md(concepts),ACE_REFERENCE.md(code/examples),ACE_DECISIONS.md(rejected alternatives)PYDANTIC_AI_MIGRATION.mdcontent into the new docs and deleted itdocs/design/Test plan
uv run pytestpassesuv run mypy ace/passes🤖 Generated with Claude Code