Conversation
|
Mike, thanks for the PR! This was a big chunk of work... I should be able to get to this a bit later this week. Stay tuned... ...and thanks again! |
|
Hey, Mike. Sorry, It took me a bit longer to get started with this than I had hoped... I was on the road this most of this last week. I did take a pretty long look at this last night though. The refactoring for the SAML 2.0 tokens seemed to work just fine, but the SAML 1.1 tokens did not. Your last bullet item (check for AssertionID or ID) seemed to be the problem. I used Azure ACS to issue SAML 1.1 tokens for the test and it used "AssertionID" rather than just "ID". I'm curious, what token issuer did you use? Was it a commercial product or something grown internally? |
|
@kbeckman Sorry for taking so long to get back to you. The token issuer is ADFS (Active Directory Federated Services). I looked around for a little bit and the examples on Wikipedia and Oracle have the AssertionID field. Oracle Wikipedia Is it possible that this field varies even within SAML 1.1? I'm thinking we could either:
|
There was a problem hiding this comment.
If you set saml_version as integer, this will not work, it would be better to case settings[:saml_version].to_s
This pull requests add support for SAML 1 Tokens. There are a couple things to note:
Let me know if you have any feedback about how this could be improved. Thanks.