Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Illustrate issue with generic request dto #145

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
import io.github.kbuntrock.resources.endpoint.generic.GenericityTestThree;
import io.github.kbuntrock.resources.endpoint.generic.GenericityTestTwelve;
import io.github.kbuntrock.resources.endpoint.generic.GenericityTestTwo;
import io.github.kbuntrock.resources.endpoint.generic.Issue144;
import io.github.kbuntrock.resources.endpoint.generic.Issue89;
import io.github.kbuntrock.resources.endpoint.generic.Issue95;
import io.github.kbuntrock.resources.endpoint.header.MultipartFileWithHeaderController;
Expand Down Expand Up @@ -833,5 +834,18 @@ public void request_headers() throws MojoFailureException, IOException, MojoExec
checkGenerationResult("ut/SpringClassAnalyserTest/request_headers.yml", generated.get(0));
}

@Test
public void generic_parent_bound_by_child() throws MojoFailureException, IOException, MojoExecutionException {

final DocumentationMojo mojo = createBasicMojo(Issue144.class.getCanonicalName());
final JavadocConfiguration javadocConfig = new JavadocConfiguration();
javadocConfig.setScanLocations(Arrays.asList("src/test/java/io/github/kbuntrock/resources/endpoint/queryparam",
"src/test/java/io/github/kbuntrock/resources/dto"));
mojo.setJavadocConfiguration(javadocConfig);

final List<File> generated = mojo.documentProject();
checkGenerationResult("ut/SpringClassAnalyserTest/query_param_dto_binding.yml", generated.get(0));
}


}
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
package io.github.kbuntrock.resources.dto.genericity.issue144;

import java.util.ArrayList;
import java.util.List;

public class BaseRequestDto< T extends BaseRequestItem> {

private List<T> priceRequestItems = new ArrayList<>();

public List<T> getPriceRequestItems() {
return priceRequestItems;
}

public void setPriceRequestItems(List<T> priceRequestItems) {
this.priceRequestItems = priceRequestItems;
}

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
package io.github.kbuntrock.resources.dto.genericity.issue144;

public class BaseRequestItem {

private String baseField;

public String getBaseField() {
return baseField;
}

public void setBaseField(String baseField) {
this.baseField = baseField;
}

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
package io.github.kbuntrock.resources.dto.genericity.issue144;

public class ChildRequestDto extends BaseRequestDto<ChildRequestItem> {

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
package io.github.kbuntrock.resources.dto.genericity.issue144;

public class ChildRequestItem extends BaseRequestItem {

private String childField;

public String getChildField() {
return childField;
}

public void setChildField(String childField) {
this.childField = childField;
}

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
package io.github.kbuntrock.resources.endpoint.generic;

import io.github.kbuntrock.resources.dto.genericity.issue144.ChildRequestDto;
import org.springframework.web.bind.annotation.PutMapping;
import org.springframework.web.bind.annotation.RequestBody;
import org.springframework.web.bind.annotation.RequestMapping;

import javax.validation.Valid;

@RequestMapping("/issue144")
public interface Issue144 {

@PutMapping(path = "/foo")
String getRequestItems(@Valid @RequestBody final ChildRequestDto priceRequest);

}