Bugfix: Calling getkey(blocking=False) results in missed keyboard inputs #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inputs are missed, because when setting `tty.setcbreak` the default value of the `when` argument is used which means that the option will have effect after transmitting all queued output and discarding all queued input which may not happen immediately so some inputs will be lost. References: - https://docs.python.org/3/library/tty.html - https://docs.python.org/3/library/termios.html#termios.tcsetattr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inputs are missed, because when setting
tty.setcbreakthe default valueof the
whenargument is used which means that the option will have effectafter transmitting all queued output and discarding all queued input which
may not happen immediately so some inputs will be lost.
References:
- https://docs.python.org/3/library/tty.html
- https://docs.python.org/3/library/termios.html#termios.tcsetattr