Skip to content

feat(find): find in the whole book, Chromium-style find bar - #619

Merged
kdroidFilter merged 2 commits into
devfrom
feat/find-in-page-whole-book
Oct 8, 2026
Merged

kdroidFilter merged 2 commits into
devfrom
feat/find-in-page-whole-book

Conversation

@kdroidFilter

Copy link
Copy Markdown
Owner

Find-in-page searches the whole book instead of only its loaded pages (#451), with a find bar modeled on Chromium's.

Depends on kdroidFilter/SeforimLibrary#104 (findInBookCandidates); the submodule points at that branch's commit until it is merged.

Find

  • Lucene narrows the book down to candidate lines, confirmed against each line's displayed text (nikud and final letters ignored); falls back to scanning the book when the index can't answer.
  • "3/861" counter; the current match is highlighted apart and centered in the viewport, loading its page if needed.
  • Narrowing while typing; results kept when the bar is closed and reopened.

Keys

  • Ctrl/Cmd+F shows and focuses the bar (never closes it), prefilled from the selection.
  • Ctrl/Cmd+G / F3 (Shift backwards), Enter / Shift+Enter, Ctrl+Enter selects the match's line, Esc closes.
  • Ctrl+Home / Ctrl+End reach the first / last line of the whole book.
  • Find keys only act on a search tab or an open book.

Other

  • Commentator names drop " על " only when the title ends there or is followed by a separator.

Tests: BookFindMatchesTest, FindInPageCommandsTest, FindFieldSyncTest, CommentatorNameTest, plus additions to SelectionContextTest and SearchHighlightingIntegrationTest.

- Matches across the whole book, not only its loaded pages (#451): Lucene
  candidates confirmed against each line's displayed text, "3/861" counter,
  current match highlighted and centered
- Ctrl/Cmd+F shows and focuses the bar (prefilled from the selection),
  Ctrl/Cmd+G and F3 step, Ctrl+Enter selects the match's line, Ctrl+Home/End
  reach the book's edges
- Commentator names drop the current book's title only when it ends there

Signed-off-by: Elie Gambache <elyahou.hadass@gmail.com>
Signed-off-by: Elie Gambache <elyahou.hadass@gmail.com>
@kdroidFilter
kdroidFilter merged commit 70641fe into dev Oct 8, 2026
2 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant