Repository navigation
feat(find): find in the whole book, Chromium-style find bar - #619
Merged
Merged
Conversation
- Matches across the whole book, not only its loaded pages (#451): Lucene candidates confirmed against each line's displayed text, "3/861" counter, current match highlighted and centered - Ctrl/Cmd+F shows and focuses the bar (prefilled from the selection), Ctrl/Cmd+G and F3 step, Ctrl+Enter selects the match's line, Ctrl+Home/End reach the book's edges - Commentator names drop the current book's title only when it ends there Signed-off-by: Elie Gambache <elyahou.hadass@gmail.com>
Signed-off-by: Elie Gambache <elyahou.hadass@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Find-in-page searches the whole book instead of only its loaded pages (#451), with a find bar modeled on Chromium's.
Depends on kdroidFilter/SeforimLibrary#104 (
findInBookCandidates); the submodule points at that branch's commit until it is merged.Find
Keys
Other
Tests:
BookFindMatchesTest,FindInPageCommandsTest,FindFieldSyncTest,CommentatorNameTest, plus additions toSelectionContextTestandSearchHighlightingIntegrationTest.