Add AboutBox and refactor MainForm for better clarity #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new `AboutBox` class along with its designer and resource files, providing an interface for displaying application information. The `MainForm` is updated to include a Help menu with an About option that opens the new dialog. Refactoring includes changing the file tasks collection to a private readonly type for improved encapsulation, updating event handler names for clarity, and simplifying code for better readability. Unused `using` directives have been removed from `CheckCommand.cs` and `Checker.cs`.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces an AboutBox component to the FileHasher application and refactors MainForm code for improved clarity and maintainability. The changes include adding a Help menu with an About option, improving encapsulation with a private readonly collection, and cleaning up unused imports.
Key changes:
- Added complete AboutBox implementation with dialog form and version display functionality
- Refactored MainForm with better naming conventions, improved encapsulation, and code simplification
- Removed unused using directives from library components
Reviewed Changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| FileHasher.Library/Checker.cs | Removed unused System using directive |
| FileHasher.GUI.WinForms/MainForm.cs | Major refactoring with improved naming, encapsulation, and code simplification |
| FileHasher.GUI.WinForms/AboutBox.resx | Added complete resource file for AboutBox dialog |
| FileHasher.GUI.WinForms/AboutBox.cs | Added new AboutBox class with version display functionality |
| FileHasher.CLI.Commands/CheckCommand.cs | Removed unused System.Text using directive |
Files not reviewed (2)
- FileHasher.GUI.WinForms/AboutBox.Designer.cs: Language not supported
- FileHasher.GUI.WinForms/MainForm.Designer.cs: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add AboutBox and refactor MainForm for better clarity
This commit introduces a new
AboutBoxclass along with its designer and resource files, providing an interface for displaying application information. TheMainFormis updated to include a Help menu with an About option that opens the new dialog.Refactoring includes changing the file tasks collection to a private readonly type for improved encapsulation, updating event handler names for clarity, and simplifying code for better readability. Unused
usingdirectives have been removed fromCheckCommand.csandChecker.cs.