Added option to inject CSS Styles into the generated HTML#42
Open
benbek wants to merge 3 commits intokdzwinel:masterfrom
Open
Added option to inject CSS Styles into the generated HTML#42benbek wants to merge 3 commits intokdzwinel:masterfrom
benbek wants to merge 3 commits intokdzwinel:masterfrom
Conversation
Puts all CSS styles into the HTML as “style” attribute. This approach is well suited to environments where one cannot have HTML with an accompanying CSS file. Shortcomings: - Not all CSS rules are convertible to HTML Style attributes. For example, no pseudo-selectors (such as ’:hover’, ‘:before’, ‘:after’) can be rendered.
Owner
|
Looks great! I'll try it out (and merge it) this week. |
Encountered this while trying to capture /html/body out of: http://www.amazon.com/SQL-Queries-Mere-Mortals-Manipulation/dp/0321992474/ref=redir_mobile_desktop?ie=UTF8&keywords=%7Bquery%7D&qid=1457617864&ref_=mp_s_a_1_1&sr=8-1 Also makes the cleaning process slightly faster.
|
bump |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #24.
Puts all CSS styles into the HTML as “style” attribute.
This approach is well suited to environments where one cannot have HTML
with an accompanying CSS file.
Shortcomings:
example, no pseudo-selectors (such as ’:hover’, ‘:before’, ‘:after’)
can be rendered.
Also, I felt that a more natural place for non-filters such as
SameRulesCombinerandHTMLStylesCombinerwould be a newprocessorsdirectory.