WalletRegistry.seize function implemented #2942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows the wallet owner to add all signing group members of the wallet with the given ID to the slashing queue of the staking contract. The notifier will receive reward per each group member from the staking contract notifiers treasury. The reward is scaled by the `rewardMultiplier` provided as a parameter. This function will be used by tBTC Bridge contract to slash wallet signing group members.
nkuba
reviewed
Apr 25, 2022
This version contains fixes for the gas cost of slashing.
…g contract The change in the staking contract modified how authorized stake is reduced after slashing, making the reduction "global", to all authorized applications, and not only "local" to a single application, as it was initially. The original approach was to decrease authorization on the slashing application and decrease authorizations on other applications only if necessary, that is, if the staked amount after the slashing was lower than the authorization on the other application. For example, let's assume the staking provider has 1000 T delegated and three applications authorized: - A application authorized for 950 T - B application authorized for 500 T - C application authorized for 100 T If C slashed for 50 T, authorization on C would be reduced by 50 T, to 100 - 50 = 50 T. If A slashed for 950 T, authorizations on A would be reduced to 0, and authorizations on B and C would be reduced to 50 T. The new approach assumes all applications are decreasing authorizations in case of slashing, no matter which application executed the slash. If C slashed for 50 T, authorization on A would be reduced to 950 - 50 = 900 T, authorization on B would be reduced to 500 - 50 = 450 T, and authorization on C would be reduced to 100 - 50 = 50 T. If A slashed for 950 T, authorizations on A, B, and C would be reduced to 0 T. The unit tests had to be adjusted to reflect the new reality. See threshold-network/solidity-contracts#87
The whole point of this function is to be called by wallet owner who is working with IWalletRegistry interface.
`WalletRegistry.seize` reverts if the staking contract call reverts. The calling code needs to take it into account and handle the potential revert properly.
|
This PR is ready for another chance @nkuba. |
There is no easy way to implement this test right now.
nkuba
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2927
Allows the wallet owner to add all signing group members of the wallet with the given ID to the slashing queue of the staking contract. The notifier will receive reward per each group member from the staking contract notifiers treasury. The reward is scaled by the
rewardMultiplierprovided as a parameter.This function will be used by tBTC Bridge contract to slash wallet signing group members.
The gas cost of calling this function when slashing all 100 members of the group is ~3M gas.
This cost was captured after upgrading
@threshold-network/solidity-contractsdependency to include the gas cost fix from threshold-network/solidity-contracts#87.After upgrading the dependency, I had to fix the unit tests for
WalletRegistryauthorizations to take into account the change of the behavior in the staking contract. This was done in the commit a5a83e7.