Open
Conversation
05a1569 to
e1f2ea1
Compare
Mohiiit
approved these changes
Mar 31, 2026
prkpndy
approved these changes
Apr 1, 2026
| use crate::constants::{MAX_CONCURRENT_PROOF_REQUESTS, MAX_STORAGE_KEYS_PER_REQUEST, STARKNET_RPC_VERSION}; | ||
| use crate::types::{ClassProof, ContractProof}; | ||
|
|
||
| const RPC_REQUEST_TIMEOUT_SECS: u64 = 15; |
Collaborator
There was a problem hiding this comment.
should we increase it? might be small for larger proofs on slow connections!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rpc-client's existingcairo_nativefeature through toblockifier/cairo_nativeRunnableCompiledClass::V1Nativewhen computing compiled class hash v2rpc-client'scairo_nativefeature fromgenerate-piereqwestdependency withstarknet-rust-providerssorpc-clientcan construct a customHttpTransportclientWhy
Madara now builds
madaraandorchestratorin a unified workspace dependency graph. In that graph,blockifieris built withcairo_native, which exposesRunnableCompiledClass::V1Native.Upstream
rpc-clientstill assumed onlyV0/V1inget_compiled_class_hash_v2, so downstream consumers had to patch SNOS locally. This PR started as the smallest upstream fix needed to let downstreams consume SNOS without a vendoredrpc-clientoverride.After wiring Madara directly to this branch and running
orchestrator::tests::jobs::snos_job::test_process_jobagainst Sepolia block2934726, there was still a separate runtime issue: the native path could hang indefinitely on the firstget_nonce_atstate read. The underlying JSON-RPC call returned immediately withcurl, but SNOS's Rust transport had no bounded connect/request timeout, so a stuck HTTP future never errored and the retry logic instate_readernever regained control.The additional timeout fix in this branch addresses that runtime failure mode. Aligning SNOS's direct
reqwestdependency withstarknet-rust-providerswas required to useHttpTransport::new_with_client(...)with a bounded client.Validation
cargo check -p rpc-clientcargo check -p rpc-client --features cairo_nativecargo check -p generate-pieapollo_starknet_os_programrequirescairo-compilefrom the sequencer venv/toolchain (Failed to get cairo-compile version: No such file or directory)cargo test -p orchestrator --features testing tests::jobs::snos_job::test_process_job -- --exact --nocapture