Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Refactor incident processing to use IncidentBl with sessions #4013

Conversation

VladimirFilonov
Copy link
Contributor

Simplified incident handling by integrating IncidentBl for database operations and ensured session-based transaction management. Replaced direct DB calls with business logic methods for better modularity and maintainability. Improved logging structure and alert syncing logic for consistency.

Closes #4000

📑 Description

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

Simplified incident handling by integrating `IncidentBl` for database operations and ensured session-based transaction management. Replaced direct DB calls with business logic methods for better modularity and maintainability. Improved logging structure and alert syncing logic for consistency.
Copy link

vercel bot commented Mar 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Mar 13, 2025 0:47am

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. Incident labels Mar 13, 2025
Added the `generated_by_ai` parameter to update_incident calls to explicitly mark incidents not generated by AI. This ensures clearer distinction between AI-generated and manually-created incidents.
@VladimirFilonov VladimirFilonov merged commit d025ba8 into main Mar 13, 2025
16 of 17 checks passed
@VladimirFilonov VladimirFilonov deleted the fix/4000-bug-incident-status-change-does-not-trigger-workflows branch March 13, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Incident size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Incident status change does not trigger workflows
2 participants