chore: update to aws-sdk-go-v2

[tekenstam]

Migrate upgrade-manager to AWS SDK Go v2

Overview

This PR completes the migration from AWS SDK Go v1 to v2, updating all dependencies, core application logic, and test infrastructure to be fully compatible with the new SDK version.

Changes Made

Dependencies

• Updated go.mod: Replaced github.com/aws/aws-sdk-go v1 with v2 modules:
  • github.com/aws/aws-sdk-go-v2
  • github.com/aws/aws-sdk-go-v2/config
  • github.com/aws/aws-sdk-go-v2/service/autoscaling
  • github.com/aws/aws-sdk-go-v2/service/ec2
  • github.com/aws/smithy-go
• Removed: github.com/keikoproj/aws-sdk-go-cache (v1 specific)

Core Application Changes

• main.go: Updated AWS client initialization to use v2's config.LoadDefaultConfig() and NewFromConfig() patterns
• AWS Provider Layer: Migrated all AWS API calls to use v2 types and patterns:
  • Context-aware API calls with context.TODO()
  • Updated pagination from Pages methods to direct API calls for better testability
  • Type changes: *int64 → *int32 for DesiredCapacity, *string → enum types for LifecycleState
• Removed Custom Retry Logic: AWS SDK Go v2 has built-in retry mechanisms, eliminating need for custom retry.go

Testing Infrastructure Overhaul

Following AWS SDK Go v2 testing best practices:

• Created Interface Layer: Added interfaces.go with AutoScalingAPI and EC2API interfaces for dependency injection
• Updated AmazonClientSet: Now uses interfaces instead of concrete client types
• Proper v2 Mocks: Implemented mock structs that satisfy the interfaces with correct v2 method signatures
• Restored All Tests: Uncommented and fixed all previously disabled test code

Files Modified

• go.mod / go.sum - Dependency updates
• main.go - Client initialization
• controllers/providers/aws/ - All AWS provider files migrated to v2
• controllers/providers/aws/interfaces.go - NEW: Interface definitions for testing
• controllers/helpers_test.go - Updated mock implementations
• controllers/upgrade_test.go - Restored test client assignments
• controllers/cloud.go - Updated type definitions
• controllers/rollingupgrade_controller.go - Removed cache config
• controllers/common/log/retry.go - DELETED: No longer needed with v2's built-in retry

Testing

• ✅ All 26 tests passing
• ✅ Application builds successfully
• ✅ No tests removed or permanently disabled
• ✅ Full compatibility with AWS SDK Go v2 patterns

Breaking Changes

• Removed CacheConfig field from RollingUpgradeReconciler (cache functionality built into v2)
• Internal AWS client interfaces changed (no external API impact)

Migration Benefits

• Better Performance: v2's improved retry logic and connection pooling
• Enhanced Security: Built-in credential chain improvements
• Future-Proof: v1 is in maintenance mode, v2 is actively developed
• Reduced Dependencies: Eliminated need for separate caching library

[codecov-commenter]

Codecov Report

❌ Patch coverage is 77.85235% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.63%. Comparing base (854444f) to head (e350208).
⚠️ Report is 18 commits behind head on master.

Files with missing lines	Patch %	Lines
controllers/providers/aws/utils.go	50.00%	19 Missing ⚠️
controllers/upgrade.go	76.74%	7 Missing and 3 partials ⚠️
controllers/providers/aws/ec2.go	91.83%	3 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #527      +/-   ##
==========================================
+ Coverage   36.00%   45.63%   +9.63%     
==========================================
  Files          14       14              
  Lines        1400     1433      +33     
==========================================
+ Hits          504      654     +150     
+ Misses        840      724     -116     
+ Partials       56       55       -1     

Files with missing lines	Coverage Δ
controllers/cloud.go	66.66% <ø> (ø)
controllers/providers/aws/autoscaling.go	100.00% <100.00%> (+100.00%)	⬆️
controllers/rollingupgrade_controller.go	51.91% <ø> (-0.52%)	⬇️
controllers/providers/aws/ec2.go	95.00% <91.83%> (+95.00%)	⬆️
controllers/upgrade.go	50.53% <76.74%> (+1.60%)	⬆️
controllers/providers/aws/utils.go	57.81% <50.00%> (+57.81%)	⬆️

---

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 854444f...e350208. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.