Skip to content

Conversation

@rusxakep
Copy link
Contributor

@rusxakep rusxakep commented Dec 29, 2025

Added grip_type "extended", a reinforced grip is created with an extended outer arm to increase contact area and stability.

image

…nded outer arm to increase contact area and stability.
@rusxakep rusxakep changed the title Added grip_type "extended" feat: added grip_type "extended" Dec 29, 2025
…nded outer arm to increase contact area and stability.
Copy link
Owner

@kellervater kellervater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution 🙇 I really hoped to see someone pick up on new grip types.

I do have some concerns though:

  1. Since this extended grip adds to top and bottom, the lockpin body would hang in mid air and require supports to be printed. That would be a lot of waste. The alternative would be to print it upright which will harm stability as the layer lines run differently (I fear there would be more creep over time and/or easier break points). That said, it looks like a legit feature anyways. But I'd request documentation on these drawbacks. Ideally here.
  2. Please adhere to the conventional commits standard with your commit messages as described in the contribution guide. You'd need to amend your commit message (something like feat(core): add extended grip type). Ideally you install and run the commit hooks as they validate all requirements being met. I also saw you manually modified the makerworld files. This is not necessary as the pre-commit hooks create proper exports from the parts files.
  3. I also left some minor remarks in the code. One specifically regarding the distinguation between standard and extended (I fear there's a regression)

Let me know if you have any questions.

rusxakep and others added 2 commits December 29, 2025 12:10
@rusxakep

This comment was marked as outdated.

@rusxakep rusxakep changed the title feat: added grip_type "extended" feat(core): add extended grip type Dec 29, 2025
@rusxakep
Copy link
Contributor Author

  1. Since this extended grip adds to top and bottom, the lockpin body would hang in mid air and require supports to be printed. That would be a lot of waste. The alternative would be to print it upright which will harm stability as the layer lines run differently (I fear there would be more creep over time and/or easier break points). That said, it looks like a legit feature anyways. But I'd request documentation on these drawbacks

Modified 'extended' format to eliminate issues in 3D printing while maintaining the same reliability as 'standard'

…aintaining the same reliability as 'standard'
…aintaining the same reliability as 'standard'
…aintaining the same reliability as 'standard'
@rusxakep rusxakep requested a review from kellervater December 29, 2025 16:06
Copy link
Owner

@kellervater kellervater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a clean solution.
Thanks so much for taking my remarks into account.
absolutely LGTM 🚀
THANKS for your great contribution!

@kellervater
Copy link
Owner

@rusxakep the only thing you'd still need to do before we can merge it, is to run the pre-commit hooks locally (see failing CI job).
They will fix general file-endings and create the proper makerworld export files.

@rusxakep
Copy link
Contributor Author

image Done!

@rusxakep rusxakep requested a review from kellervater December 31, 2025 11:46
Copy link
Owner

@kellervater kellervater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect! thank you!

@kellervater kellervater merged commit 7e4b27a into kellervater:main Dec 31, 2025
3 checks passed
kellervater-release-please bot added a commit that referenced this pull request Jan 5, 2026
🤖 I have created a release *beep* *boop*
---


<details><summary>homeracker: 1.6.0</summary>

##
[1.6.0](homeracker-v1.5.2...homeracker-v1.6.0)
(2026-01-04)


### ✨ Features

* **core:** add extended grip type
([#173](#173))
([7e4b27a](7e4b27a))


### 📦 Dependencies

* update camunda/infra-global-github-actions digest to 084e5ba
([#184](#184))
([0be0d09](0be0d09))
* update camunda/infra-global-github-actions digest to 309fedf
([#180](#180))
([e627303](e627303))
* update dependency openscad-windows to v2026.01.03
([#186](#186))
([fce4a5a](fce4a5a))
* update openscad nightly to v2026
([#182](#182))
([45efd5c](45efd5c))
* update pre-commit hook renovatebot/pre-commit-hooks to v42.70.3
([#183](#183))
([b391b09](b391b09))
* update pre-commit hook renovatebot/pre-commit-hooks to v42.71.0
([#185](#185))
([bf326b5](bf326b5))
* update pre-commit hooks
([#181](#181))
([4748876](4748876))


### 📚 Documentation

* add Community section to README
([#175](#175))
([71dbee8](71dbee8))
* pre-commit.dev -&gt; pre-commit.com fixes
([#179](#179))
([3e61b1a](3e61b1a))
* updated CONTRIBUTING.md minor inaccuracies
([#178](#178))
([a45cc3c](a45cc3c))
</details>

<details><summary>scadm: 0.4.3</summary>

##
[0.4.3](scadm-v0.4.2...scadm-v0.4.3)
(2026-01-04)


### 📦 Dependencies

* update dependency openscad-windows to v2026.01.03
([#186](#186))
([fce4a5a](fce4a5a))
* update openscad nightly to v2026
([#182](#182))
([45efd5c](45efd5c))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: kellervater-release-please[bot] <185213673+kellervater-release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants