Skip to content

Enable running the example offline #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enable running the example offline #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions examples/randomuser-sqlite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,14 @@
import requests
import records

# Fetch random user data from randomuser.me API
response = requests.get('http://api.randomuser.me/0.6/?nat=us&results=10')
user_data = response.json()['results']
# Fetch random user data from randomuser.me API or load if not available
try:
response = requests.get('http://api.randomuser.me/0.6/?nat=us&results=10')
except response.status_code != 200:
with open('saved_response.json') as saved_response:
user_data = saved_response.read()
Comment on lines +12 to +13
Copy link

@coderabbitai coderabbitai bot Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Path to saved_response.json needs to be fixed.

The script attempts to open 'saved_response.json' directly, but the file is located in the 'examples' directory. The relative path needs to be corrected for the fallback mechanism to work properly.

-    with open('saved_response.json') as saved_response:
+    with open('examples/saved_response.json') as saved_response:
        user_data  = saved_response.read()
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
with open('saved_response.json') as saved_response:
user_data = saved_response.read()
with open('examples/saved_response.json') as saved_response:
user_data = saved_response.read()

Copy link

@coderabbitai coderabbitai bot Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

JSON parsing missing for the saved response.

The script reads the saved response as a raw string, but it needs to parse it into a Python object to match the format expected by the code that processes user data.

    with open('examples/saved_response.json') as saved_response:
-        user_data  = saved_response.read()
+        user_data  = json.loads(saved_response.read())
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
user_data = saved_response.read()
with open('examples/saved_response.json') as saved_response:
user_data = json.loads(saved_response.read())

else:
user_data = response.json()['results']
Comment on lines +8 to +15
Copy link

@coderabbitai coderabbitai bot Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Critical error in exception handling syntax.

The except clause contains a conditional expression (response.status_code != 200) rather than an exception class. This will cause a syntax error when the script runs.

Fix the exception handling with this approach:

# Fetch random user data from randomuser.me API or load if not available
try:
    response = requests.get('http://api.randomuser.me/0.6/?nat=us&results=10')
-except response.status_code != 200:
+    if response.status_code != 200:
+        raise Exception(f"API request failed with status code {response.status_code}")
+    user_data = response.json()['results']
+except Exception as e:
    with open('saved_response.json') as saved_response:
        user_data  = saved_response.read()
-else:
-    user_data = response.json()['results']
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
# Fetch random user data from randomuser.me API or load if not available
try:
response = requests.get('http://api.randomuser.me/0.6/?nat=us&results=10')
except response.status_code != 200:
with open('saved_response.json') as saved_response:
user_data = saved_response.read()
else:
user_data = response.json()['results']
# Fetch random user data from randomuser.me API or load if not available
try:
response = requests.get('http://api.randomuser.me/0.6/?nat=us&results=10')
if response.status_code != 200:
raise Exception(f"API request failed with status code {response.status_code}")
user_data = response.json()['results']
except Exception as e:
with open('saved_response.json') as saved_response:
user_data = saved_response.read()
🧰 Tools
🪛 Ruff (0.8.2)

11-11: except handlers should only be exception classes or tuples of exception classes

(B030)


# Database connection string
DATABASE_URL = 'sqlite:///users.db'
Expand Down
1 change: 1 addition & 0 deletions examples/saved_response.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
[{"user": {"gender": "female", "name": {"title": "ms", "first": "rita", "last": "rhodes"}, "location": {"street": "7662 cowper st", "city": "mesquite", "state": "arizona", "zip": "64557"}, "email": "[email protected]", "username": "greenfish186", "password": "2002", "salt": "Ks08pBCZ", "md5": "02e1a9f463057b9589bdd4f00f2a19d3", "sha1": "2e9369a1183d9cf96383fe1e62ff1c79e5b68d2a", "sha256": "a2150bcb967be22d1eee427cb17f2e1edd9475913987a9e5338a28e3350a6c9f", "registered": "1348619616", "dob": "268717353", "phone": "(872)-472-1648", "cell": "(755)-928-7974", "SSN": "692-75-4553", "picture": {"large": "http://api.randomuser.me/portraits/women/96.jpg", "medium": "http://api.randomuser.me/portraits/med/women/54.jpg", "thumbnail": "http://api.randomuser.me/portraits/thumb/women/93.jpg"}, "version": "0.6", "nationality": "US"}, "seed": "e4db96a3bc6a78a7"}, {"user": {"gender": "female", "name": {"title": "ms", "first": "leah", "last": "wheeler"}, "location": {"street": "3150 dane st", "city": "henderson", "state": "minnesota", "zip": "15952"}, "email": "[email protected]", "username": "brownbear550", "password": "teacher", "salt": "MPnoHrsM", "md5": "499b2b397966e751645ad7a6075862ff", "sha1": "dd4b861c00857af08d2eac65173240b4c0195faf", "sha256": "31267d265abb5d336db6ac7f1bb91a70f9e739797b98e3f475813935f5e46648", "registered": "1430903007", "dob": "465166229", "phone": "(278)-103-2010", "cell": "(351)-639-9972", "SSN": "341-49-4765", "picture": {"large": "http://api.randomuser.me/portraits/women/0.jpg", "medium": "http://api.randomuser.me/portraits/med/women/16.jpg", "thumbnail": "http://api.randomuser.me/portraits/thumb/women/12.jpg"}, "version": "0.6", "nationality": "US"}}, {"user": {"gender": "female", "name": {"title": "ms", "first": "hazel", "last": "washington"}, "location": {"street": "3745 poplar dr", "city": "minneapolis", "state": "georgia", "zip": "24561"}, "email": "[email protected]", "username": "brownpeacock412", "password": "bowser", "salt": "GPDhoZxB", "md5": "a932df52d2c39394315a637261378eee", "sha1": "667dc34cb9461a1307bb74fd92b210648846745a", "sha256": "16e4985dbb804d3f55279b6f62915cc88bb70a99fd4d9bbcfbfa11a79e667a8f", "registered": "1155030518", "dob": "258282983", "phone": "(581)-360-2118", "cell": "(111)-716-7872", "SSN": "908-11-8083", "picture": {"large": "http://api.randomuser.me/portraits/women/42.jpg", "medium": "http://api.randomuser.me/portraits/med/women/69.jpg", "thumbnail": "http://api.randomuser.me/portraits/thumb/women/35.jpg"}, "version": "0.6", "nationality": "US"}}, {"user": {"gender": "male", "name": {"title": "mr", "first": "lucas", "last": "fox"}, "location": {"street": "5810 homestead rd", "city": "ronkers", "state": "vermont", "zip": "81971"}, "email": "[email protected]", "username": "brownsnake721", "password": "love123", "salt": "r3SNKnpI", "md5": "168ab1906da0677545eb852174563c3e", "sha1": "056b3fb0aa21292aea40363a2619d40669db9b84", "sha256": "cfcac96a2fc62a2db3b35706b78645b97859a7ac3524c7940a7c522b7f15ddde", "registered": "1056619353", "dob": "272367829", "phone": "(160)-848-1198", "cell": "(369)-822-8877", "SSN": "505-30-8155", "picture": {"large": "http://api.randomuser.me/portraits/men/28.jpg", "medium": "http://api.randomuser.me/portraits/med/men/12.jpg", "thumbnail": "http://api.randomuser.me/portraits/thumb/men/53.jpg"}, "version": "0.6", "nationality": "US"}}, {"user": {"gender": "female", "name": {"title": "miss", "first": "mae", "last": "martinez"}, "location": {"street": "2262 n stelling rd", "city": "philadelphia", "state": "georgia", "zip": "54153"}, "email": "[email protected]", "username": "blackgorilla982", "password": "diamond1", "salt": "V3dCfRsw", "md5": "73fbb795085f57598e022fa36565cc8c", "sha1": "376fc5a7816ca7e58568ebdec7639bad887cb2de", "sha256": "aefc5d0398e98429f183f2d0a491e2d914a206c3f3f7a46042499ad76786e468", "registered": "1339079332", "dob": "338408263", "phone": "(612)-692-1144", "cell": "(425)-764-8815", "SSN": "617-12-8663", "picture": {"large": "http://api.randomuser.me/portraits/women/49.jpg", "medium": "http://api.randomuser.me/portraits/med/women/23.jpg", "thumbnail": "http://api.randomuser.me/portraits/thumb/women/11.jpg"}, "version": "0.6", "nationality": "US"}}, {"user": {"gender": "female", "name": {"title": "miss", "first": "meghan", "last": "campbell"}, "location": {"street": "3971 watika st", "city": "anaheim", "state": "illinois", "zip": "94518"}, "email": "[email protected]", "username": "crazypanda943", "password": "klondike", "salt": "e9qREWyS", "md5": "9468e486406db8b1158fa262bcfd2dc6", "sha1": "7e5313e4036c28cd306e4d695223d46e253a6743", "sha256": "242610f38eb9f9e56b6f1268bea401fb39051f6b1507bc2f0e9819c27fc43e00", "registered": "1537749468", "dob": "161385273", "phone": "(279)-626-9238", "cell": "(654)-711-2363", "SSN": "340-48-6449", "picture": {"large": "http://api.randomuser.me/portraits/women/89.jpg", "medium": "http://api.randomuser.me/portraits/med/women/18.jpg", "thumbnail": "http://api.randomuser.me/portraits/thumb/women/3.jpg"}, "version": "0.6", "nationality": "US"}}, {"user": {"gender": "male", "name": {"title": "mr", "first": "bernard", "last": "garcia"}, "location": {"street": "7296 victoria dr", "city": "sunnyvale", "state": "iawaii", "zip": "31784"}, "email": "[email protected]", "username": "smallwolf347", "password": "2005", "salt": "LBCcDC2l", "md5": "6149e9517973adbda0540b36fab24d3f", "sha1": "87c8c15bddde991c48263b5c0648a23929f08e6a", "sha256": "581d82610041723caeb8634cfe9ed37ef5d3f32839f335d00a73e7b6a24caff9", "registered": "1390590936", "dob": "445976540", "phone": "(630)-809-9231", "cell": "(819)-603-9781", "SSN": "484-25-3775", "picture": {"large": "http://api.randomuser.me/portraits/men/51.jpg", "medium": "http://api.randomuser.me/portraits/med/men/30.jpg", "thumbnail": "http://api.randomuser.me/portraits/thumb/men/53.jpg"}, "version": "0.6", "nationality": "US"}}, {"user": {"gender": "male", "name": {"title": "mr", "first": "marvin", "last": "shaw"}, "location": {"street": "3662 sunset blvd", "city": "farmers branch", "state": "new jersey", "zip": "21275"}, "email": "[email protected]", "username": "goldenswan492", "password": "cabernet", "salt": "GCICQf6a", "md5": "969713b868f95f440c0aeafcaa1ad76e", "sha1": "4adcf8efc51f1a89bfc890a4a9244b8c22bdc1e1", "sha256": "02b17892cc28489b1556aaa6dc1de457ed3b662a6a23aab08c1f27b7f7580446", "registered": "1543942029", "dob": "372296855", "phone": "(339)-759-6889", "cell": "(463)-650-8607", "SSN": "986-41-7807", "picture": {"large": "http://api.randomuser.me/portraits/men/94.jpg", "medium": "http://api.randomuser.me/portraits/med/men/24.jpg", "thumbnail": "http://api.randomuser.me/portraits/thumb/men/68.jpg"}, "version": "0.6", "nationality": "US"}}, {"user": {"gender": "male", "name": {"title": "mr", "first": "ramon", "last": "payne"}, "location": {"street": "7246 crosstimber ct", "city": "sioux falls", "state": "tennessee", "zip": "17738"}, "email": "[email protected]", "username": "ticklishpeacock688", "password": "town", "salt": "GWgZOvgg", "md5": "ed91d2e74775419af5623991b47ebf44", "sha1": "ecb57b7ffe00e7f60cde3d31ef17fc48f55f8591", "sha256": "a835739c1d53615a00f12735cddee8158786fb913e9f8dc00cd1b1d7d7175e3f", "registered": "1004997452", "dob": "145691375", "phone": "(452)-321-8264", "cell": "(229)-903-2744", "SSN": "862-54-3039", "picture": {"large": "http://api.randomuser.me/portraits/men/54.jpg", "medium": "http://api.randomuser.me/portraits/med/men/68.jpg", "thumbnail": "http://api.randomuser.me/portraits/thumb/men/26.jpg"}, "version": "0.6", "nationality": "US"}}, {"user": {"gender": "male", "name": {"title": "mr", "first": "curtis", "last": "riley"}, "location": {"street": "7228 cavour ave", "city": "henderson", "state": "new jersey", "zip": "36618"}, "email": "[email protected]", "username": "greenwolf555", "password": "infiniti", "salt": "sEhJMl20", "md5": "8b4400466b5da8d2b641ba045b286a70", "sha1": "e6858775de45a7c2239d077a14d7c9bc6a817ba2", "sha256": "2e345a33e6e1fb4453a4a8581a7abf6484da0303e7360465f3e4023d5ba881d8", "registered": "1109449325", "dob": "287900192", "phone": "(567)-716-9898", "cell": "(977)-698-2241", "SSN": "506-55-6487", "picture": {"large": "http://api.randomuser.me/portraits/men/33.jpg", "medium": "http://api.randomuser.me/portraits/med/men/37.jpg", "thumbnail": "http://api.randomuser.me/portraits/thumb/men/80.jpg"}, "version": "0.6", "nationality": "US"}}]