Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InceptionNet #2154

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

InceptionNet #2154

wants to merge 10 commits into from

Conversation

yugborana
Copy link

Adding InceptionNet backbone Functionalities...

@yugborana
Copy link
Author

@JyotinderSingh Now I think it is good to go, I have tried to resolve the test issues...

@yugborana
Copy link
Author

@JyotinderSingh Good evening. Would you please review?

@JyotinderSingh JyotinderSingh self-assigned this Mar 25, 2025
@JyotinderSingh
Copy link
Collaborator

Hi @yugborana, looks like the CI is breaking due to some import errors. Could you please take a look?

@yugborana
Copy link
Author

@JyotinderSingh solved the issue

@yugborana
Copy link
Author

Again import error came. Let me resolve and inform...

Copy link
Collaborator

@JyotinderSingh JyotinderSingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing @yugborana! I've left a few minor comments.

@JyotinderSingh
Copy link
Collaborator

Please also include a numerics verification colab notebook which verifies the outputs of this implementation against a reference. Ideally this implementation's outputs would be within a reasonable margin of error.

@JyotinderSingh
Copy link
Collaborator

JyotinderSingh commented Mar 27, 2025

The formatter also seems to be failing, please reformat the code using instructions present here.

@yugborana
Copy link
Author

Please also include a numerics verification colab notebook which verifies the outputs of this implementation against a reference. Ideally this implementation's outputs would be within a reasonable margin of error.

tried to make it but an import error coming again and again. I will try to resolve

@yugborana
Copy link
Author

The formatter also seems to be failing, please reformat the code using instructions present here.

yeah, resolving it

@yugborana
Copy link
Author

@JyotinderSingh Tried to resolve issues but something is failing again and again. Would like to request whenever you have time to go through it and leave some comments, it would be a great help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants