Skip to content

Conversation

sachinprasadhs
Copy link
Collaborator

@sachinprasadhs sachinprasadhs commented Oct 15, 2025

Description of the change

Reference

Colab Notebook

Checklist

  • I have added all the necessary unit tests for my change.
  • I have verified that my change does not break existing code and works with all backends (TensorFlow, JAX, and PyTorch).
  • My PR is based on the latest changes of the main branch (if unsure, rebase the code).
  • I have followed the Keras Hub Model contribution guidelines in making these changes.
  • I have followed the Keras Hub API design guidelines in making these changes.
  • I have signed the Contributor License Agreement.

Copy link
Contributor

Summary of Changes

Hello @sachinprasadhs, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates the PARSeq model into the Keras Hub ecosystem by establishing its preset configurations and ensuring proper registration. It also refines the checkpoint conversion process for PARSeq models, streamlining their inclusion and management within the system.

Highlights

  • Register PARSeq Presets: The PARSeq model's presets are now registered within the Keras Hub system, making them discoverable and usable.
  • Define PARSeq ViT Preset: A new file parseq_presets.py has been added to define the configuration for the 'parseq_vit' model, including its description, parameter count, and Kaggle handle.
  • Update Checkpoint Conversion Script: The convert_parseq_checkpoints.py script has been updated to use a simplified preset key ('parseq' instead of 'parseq_vit') and now explicitly calls save_to_preset to ensure converted models are properly saved.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request registers a new preset for the PARSeq model. The changes include adding the preset definition, a script to convert checkpoints, and registering the preset. The code is well-structured, but there is an inconsistency in the preset naming between the definition file and the conversion script. I've suggested a change to align the preset name to parseq across all files to ensure it can be loaded correctly and adheres to the repository's consistency principle.

@laxmareddyp laxmareddyp self-requested a review October 20, 2025 20:16
Copy link
Collaborator

@laxmareddyp laxmareddyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sachinprasadhs sachinprasadhs merged commit e2d7095 into keras-team:master Oct 20, 2025
8 checks passed
@sachinprasadhs sachinprasadhs deleted the parseq_preset branch October 20, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants