-
Notifications
You must be signed in to change notification settings - Fork 303
register mobilenet presets #2443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
register mobilenet presets #2443
Conversation
Summary of ChangesHello @sachinprasadhs, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates new preset configurations for the MobileNetV5 model into Keras Hub, specifically adding a preset for a 300M-parameter vision encoder used with Gemma 3n. This enhancement makes the model more readily usable with pre-defined configurations and enables comprehensive testing of these presets. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request registers a new preset for MobileNetV5, mobilenetv5_300m_enc_gemma3n
. The changes include adding the preset definition, registering it, and enabling the corresponding test. My review found an important inconsistency in how this new preset name is used across different files, which will cause tests to fail. Please correct the preset name in the test file and the docstring example to match the definition in mobilenetv5_presets.py
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of the change
Reference
Colab Notebook
Checklist