-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Adds GPTQ Quantization Documentation #2196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @JyotinderSingh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new, detailed guide on GPTQ quantization for Keras and KerasHub models. The documentation aims to equip users with the knowledge and tools to apply weight-only quantization, significantly reducing model size and memory requirements while maintaining high model quality. It covers the theoretical background, practical implementation steps, and performance implications of using GPTQ. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds comprehensive documentation for GPTQ quantization in Keras, including a Python guide, a Jupyter notebook, and a Markdown file. The additions are well-structured and informative. I've provided a few minor suggestions to improve clarity and consistency across the different documentation formats. Overall, this is a great contribution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
A couple of comments:
GPTQConfig
is not documented in the API, we should add itquantize
is not documented in https://keras.io/api/models/model/ , we should add it
Also, do you want to mention a couple more of the config options for GPTQ in this tutorial?
I'll create another PR to add these symbols into the API docs as well. I'm not sure if discussing other config keys will add value to the guide, since that would probably something that is more suited for the API reference. |
No description provided.