Fixes inconsistent serialization logic for inputs #20993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zation removes unnecessary imports
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20993 +/- ##
==========================================
- Coverage 82.45% 82.45% -0.01%
==========================================
Files 562 562
Lines 53303 53314 +11
Branches 8257 8258 +1
==========================================
+ Hits 43949 43958 +9
- Misses 7338 7340 +2
Partials 2016 2016
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hertschuh
requested changes
Mar 6, 2025
hertschuh
approved these changes
Mar 6, 2025
google-ml-butler
bot
added
kokoro:force-run
ready to pull
JyotinderSingh
changed the title
11happy
pushed a commit
to 11happy/keras
that referenced
this pull request
Mar 9, 2025
* Removes unnesting logic for input tensors in functional model deserialization flow * Adds test case for verifying nested input restoration after deserialization removes unnecessary imports * fixes imports
Hmm-1224
pushed a commit
to Hmm-1224/keras
that referenced
this pull request
Apr 5, 2025
* Removes unnesting logic for input tensors in functional model deserialization flow * Adds test case for verifying nested input restoration after deserialization removes unnecessary imports * fixes imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Consider a model where its
inputproperty is represented as[[[input_layer_1, 0, 0]]].When serialized and deserialized, it turns into
[[input_layer_1, 0, 0]].Fix
This change removes the input_tensor un-nesting logic from
functional_from_configmethod which adds special handling for the above case, now the code proceeds with the regular flow irrespective of triply nested input arrays and maintains consistency across serialization round-trips.