bpf: skip non existing key in generic_map_lookup_batch #4949
+45
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kernel-patches-daemon-bpf-rc[bot]](https://avatars.githubusercontent.com/u/70728002?s=60&v=4){kind=small}
|
Upstream branch: fc610c8 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf_base
branch
from
9df8ced to
928f200
Compare
|
Upstream branch: fc610c8 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/930911=>bpf
branch
from
07f2104 to
69364f2
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf_base
branch
from
928f200 to
a24f921
Compare
|
Upstream branch: fc610c8 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/930911=>bpf
branch
from
69364f2 to
7d341b0
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf_base
branch
from
a24f921 to
5a53b56
Compare
|
Upstream branch: 517e8a7 |
The generic_map_lookup_batch currently returns EINTR if it fails with ENOENT and retries several times on bpf_map_copy_value. The next batch would start from the same location, presuming it's a transient issue. This is incorrect if a map can actually have "holes", i.e. "get_next_key" can return a key that does not point to a valid value. At least the array of maps type may contain such holes legitly. Right now these holes show up, generic batch lookup cannot proceed any more. It will always fail with EINTR errors. Rather, do not retry in generic_map_lookup_batch. If it finds a non existing element, skip to the next key. Fixes: cb4d03a ("bpf: Add generic support for lookup batch op") Closes: https://lore.kernel.org/bpf/[email protected]/ Signed-off-by: Yan Zhai <[email protected]>
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/930911=>bpf
branch
from
7d341b0 to
76a57de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpf: skip non existing key in generic_map_lookup_batch
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=930911