tools/build: Use SYSTEM_BPFTOOL for system bpftool #8713
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kernel-patches-daemon-bpf[bot]](https://avatars.githubusercontent.com/u/70728002?s=60&v=4){kind=small}
When the cq reservation is failed, the error code is not set which is initialized to zero in __xsk_generic_xmit(). That means the packet is not send successfully but sendto() return ok. Considering the impact on uapi, return -EAGAIN is a good idea. The cq is full usually because it is not released in time, try to send msg again is appropriate. The bug was at the very early implementation of xsk, so the Fixes tag targets the commit that introduced the changes in xsk_cq_reserve_addr_locked where this fix depends on. Fixes: e6c4047 ("xsk: Use xsk_buff_pool directly for cq functions") Suggested-by: Magnus Karlsson <[email protected]> Signed-off-by: Wang Liang <[email protected]> Signed-off-by: Martin KaFai Lau <[email protected]> Acked-by: Stanislav Fomichev <[email protected]> Link: https://patch.msgid.link/[email protected]
|
Upstream branch: 6ccf6ad Pull request is NOT updated. Failed to apply https://patchwork.kernel.org/project/netdevbpf/list/?series=947333 conflict: |
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf_base
branch
2 times, most recently
from
43b2753 to
c13a191
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=947333 irrelevant now. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: tools/build: Use SYSTEM_BPFTOOL for system bpftool
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=947333