selftests/bpf: Fix tests after change in struct file #8718
Closed
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kernel-patches-daemon-bpf[bot]](https://avatars.githubusercontent.com/u/70728002?s=60&v=4){kind=small}
|
Upstream branch: 9aa8fe2 |
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
35ab59d to
bf339f7
Compare
|
Upstream branch: 9aa8fe2 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/947857=>bpf-next
branch
from
fe2ea28 to
c121b49
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
bf339f7 to
9809c6b
Compare
Change in struct file [1] moves f_ref to the 3rd cache line. This makes deferencing file pointer as a 8-byte variable invalid, because btf_struct_walk() will walk into f_lock, which is 4-byte long. Fix the selftests to deference the file pointer as a 4-byte variable. [1] commit e249056 ("fs: place f_ref to 3rd cache line in struct file to resolve false sharing") Reported-by: Jakub Kicinski <[email protected]> Signed-off-by: Song Liu <[email protected]>
|
Upstream branch: aa918db |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/947857=>bpf-next
branch
from
c121b49 to
92c27d1
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=947857 irrelevant now. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: selftests/bpf: Fix tests after change in struct file
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=947857