Tc tunnel ci #9966
Open
Tc tunnel ci #9966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
11 times, most recently
from
58474bc to
bd61720
Compare
The tc_tunnel test defines some convenient functions to create a qdisc and attach bpf programs to it. It would be beneficial to new tests to get those functions exported as helpers in a tc_helpers.h. There is however already a tc_helpers.h file in the BPF selftests, used by a few tests. This header is quite coupled to some BPF programs (some exposed helpers consume a skeleton from some specific BPF programs), so rename it to something more related to its original purpose. Signed-off-by: Alexis Lothoré (eBPF Foundation) <[email protected]>
The tc_tunnel.c test defines small fonctions to easily attach eBPF programs to tc hooks, either on egress, ingress or both. Move those helpers in a dedicated file so that other tests can benefit from it. Signed-off-by: Alexis Lothoré (eBPF Foundation) <[email protected]>
The test_tc_tunnel.sh checks that a large variety of tunneling mechanisms handled by the kernel can be handled as well by eBPF programs. While this test shares similarities with test_tunnel.c (which is already integrated in test_progs), those are testing slightly different things: - test_tunnel.c get and set tunnel keys in packet metadata with the corresponding bpf-helpers - test_tc_tunnels.sh manually parses/crafts packets content Bring the tests covered by test_tc_tunnel.sh into the test_progs framework, by creating a dedicated test_tc_tunnel.sh. This new test defines a "generic" runner which, for each test configuration: - will bring the relevant veth pair, each of those isolated in a dedicated namespace - will check that traffic will fail if there is only an encapsulating program attached to one veth egress - will check that traffic succeed if we enable some decapsulation module on kernel side - will check that traffic still succeeds if we replace the kernel decapsulation with some eBPF ingress decapsulation. Example of the new test execution: # ./test_progs -a tc_tunnel kernel-patches#447/1 tc_tunnel/ipip_none:OK kernel-patches#447/2 tc_tunnel/ipip6_none:OK kernel-patches#447/3 tc_tunnel/ip6tnl_none:OK kernel-patches#447/4 tc_tunnel/sit_none:OK kernel-patches#447/5 tc_tunnel/vxlan_eth:OK kernel-patches#447/6 tc_tunnel/ip6vxlan_eth:OK kernel-patches#447/7 tc_tunnel/gre_none:OK kernel-patches#447/8 tc_tunnel/gre_eth:OK kernel-patches#447/9 tc_tunnel/gre_mpls:OK kernel-patches#447/10 tc_tunnel/ip6gre_none:OK kernel-patches#447/11 tc_tunnel/ip6gre_eth:OK kernel-patches#447/12 tc_tunnel/ip6gre_mpls:OK kernel-patches#447/13 tc_tunnel/udp_none:OK kernel-patches#447/14 tc_tunnel/udp_eth:OK kernel-patches#447/15 tc_tunnel/udp_mpls:OK kernel-patches#447/16 tc_tunnel/ip6udp_none:OK kernel-patches#447/17 tc_tunnel/ip6udp_eth:OK kernel-patches#447/18 tc_tunnel/ip6udp_mpls:OK kernel-patches#447 tc_tunnel:OK Summary: 1/18 PASSED, 0 SKIPPED, 0 FAILED Signed-off-by: Alexis Lothoré (eBPF Foundation) <[email protected]>
…latforms When trying to run bpf-based encapsulation in a s390x environment, some parts of test_tc_tunnel.bpf.o do not encapsulate correctly the traffic, leading to tests failures. Adding some logs shows for example that packets about to be sent on an interface with the ip6vxlan_eth program attached do not have the expected value 5 in the ip header ihl field, and so are ignored by the program. This phenomenon appears when trying to cross-compile the selftests: rather than compiling it from a virtualized host: the selftests build system may then wrongly pick some host headers. If <asm/byteorder.h> ends up being picked on the host (and if the host has a endianess different from the target one), it will then expose wrong endianness defines (e.g __LITTLE_ENDIAN_BITFIELD instead of __BIT_ENDIAN_BITFIELD), and it will for example mess up the iphdr structure layout used in the ebpf program. To prevent this, directly use the vmlinux.h header generated by the selftests build system rather than including directly specific kernel headers. As a consequence, add some missing definitions that are not exposed by vmlinux.h, and adapt the bitfield manipulations to make the program usable on both types of platforms. Signed-off-by: Alexis Lothoré <[email protected]>
Now that test_tc_tunnel.sh scope has been ported to the test_progs framework, remove it. Signed-off-by: Alexis Lothoré (eBPF Foundation) <[email protected]>
Tropicao
force-pushed
the
tc_tunnel_ci
branch
from
8656f4d to
e2bb223
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI test run