test: add unit tests for filters helpers #1543
Open
+1,961
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| """Test is_exclusively_build_issue with known issue with test.""" | ||
| result = is_exclusively_build_issue("issue123", 1, "test123") | ||
| assert result is False | ||
|
|
There was a problem hiding this comment.
here isn't worth to add also a test for a unknown issue with valid test id?
Suggested change
| def test_is_exclusively_build_issue_with_unknown_issue_with_test(self): | |
| """Test is_exclusively_build_issue with unknown issue but with test.""" | |
| result = is_exclusively_build_issue(None, None, "test123") | |
| assert result is False | |
| issue_id=None, issue_version=None, incident_test_id="test123" | ||
| ) | ||
| assert result is False | ||
|
|
There was a problem hiding this comment.
almost same here, but with (None, None, None)
Suggested change
| def test_is_exclusively_test_issue_with_unknown_issue_no_test(self): | |
| """Test is_exclusively_test_issue with unknown issue and no test.""" | |
| result = is_exclusively_test_issue( | |
| issue_id=None, issue_version=None, incident_test_id=None | |
| ) | |
| assert result is False |
Comment on lines
+237
to
+241
| def test_filter_data(): | ||
| """Test filter data for testing.""" | ||
| return { | ||
| "path": "test.other", | ||
| "status": "PASS", |
There was a problem hiding this comment.
maybe it’s a nit, but wouldn’t it be better to avoid naming the fixture functions with the test_ prefix so pytest doesn’t collect them as tests?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase to 49%