add connectionToken property from IConnection #714
Closed
+43
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerryjiang
reviewed
Apr 22, 2024
| @@ -314,11 +314,11 @@ protected virtual ValueTask OnSessionClosedAsync(IAppSession session, CloseEvent | |||
| if (closedHandler != null) | |||
| return closedHandler.Invoke(session, e); | |||
|
|
|||
| #if NETSTANDARD2_1 | |||
| #if NETSTANDARD2_1 | |||
| return GetCompletedTask(); | |||
kerryjiang
reviewed
Apr 22, 2024
| @@ -471,20 +467,20 @@ public async Task StartAsync(CancellationToken cancellationToken) | |||
|
|
|||
| protected virtual ValueTask OnStartedAsync() | |||
| { | |||
| #if NETSTANDARD2_1 | |||
| #if NETSTANDARD2_1 | |||
| return GetCompletedTask(); | |||
kerryjiang
reviewed
Apr 22, 2024
| } | ||
|
|
||
| protected virtual ValueTask OnStopAsync() | ||
| { | ||
| #if NETSTANDARD2_1 | ||
| #if NETSTANDARD2_1 | ||
| return GetCompletedTask(); |
|
Also need think about KestrelPipeConnection. context.ConnectionClosed |
kerryjiang
reviewed
Apr 22, 2024
| @@ -52,6 +52,7 @@ protected PipeConnectionBase(PipeReader inputReader, PipeWriter outputWriter, Co | |||
| Logger = options.Logger; | |||
| InputReader = inputReader; | |||
| OutputWriter = outputWriter; | |||
| ConnectionToken = _cts.Token; | |||
| } | |||
|
|
|||
| protected virtual Task StartTask<TPackageInfo>(IObjectPipe<TPackageInfo> packagePipe) | |||
There was a problem hiding this comment.
_cts.Token can be replaced with ConnectionToken in this file. And then we will see how to improve _cts and we should let it work together with KestrelPipeConnection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.