Chore/worker refacto #4057
Merged
Chore/worker refacto #4057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loicmathieu
force-pushed
the
chore/worker-refacto
branch
3 times, most recently
from
0f526a5
to
404d058
Compare
loicmathieu
force-pushed
the
chore/worker-refacto
branch
8 times, most recently
from
d402185
to
5a38dd4
Compare
loicmathieu
force-pushed
the
chore/worker-refacto
branch
2 times, most recently
from
3737ce8
to
2e37bc2
Compare
loicmathieu
force-pushed
the
chore/worker-refacto
branch
from
2e37bc2
to
a155366
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we use 2 thread for each worker job:
This PR keeps the first thread pool as we don't want to block the queue reception (or we will deadlock in JDBC), and we need to limit concurrency. But it then uses a virtual thread to execute the task / evaluate the trigger to reduce resource consumption and switch from the low level thread API to a Callable<State.Type>.