-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ION extra to Kestra Python Package #16
base: main
Are you sure you want to change the base?
Add ION extra to Kestra Python Package #16
Conversation
Nice one, really appreciate that you handle java time nativelly ! Some quick idea:
with both, I think we will remove all the complexity to understand how kestra is working. WDYT? |
Hello @tchiotludo ! Kestra "read" is not a function currently, are you proposing to add that to Python Kestra? For Could you elaborate on your propositions, I feel like I lack understanding 😅 ? Thank you 😸 ! |
For the read, I would just change the For the write, I would love to see |
@tchiotludo , ohhhhhhhhhhhhhhh I am following now. Sorry, I copied this package over from Anna's repo, and was trying to make it backwards compatible in this manner
Is it ok if I don't have it import like that? Because if so, I can play around with your thoughts - they make more sense now 😄 -- For now, I will move |
What changes are being made and why?
added Kestra ION package as extra to Kestra Python Package
kept the repo code 99% the same, just changed around file names so that
from kestra_ion import read_ion
worked as before - which makes it backward compatibleadded to documentation and tests to cover the new ION extra update
we will probably want to update other docs that reference Kestra-ION repo, and not shut down that repo for time being, in case users do not see this new extra (I also won't probably have time to update to use new extra for a week or two)
closes Add kestra-ion as subpackage to kestra #11
closes Kestra Flow Triggering Attempts to Poll Execution before it's created #17
How the changes have been QAed?
can confirm
pip install kestra
does not install the Kestra ION packagemain.py file -