Fixed some warnings

kevin-belellou · Feb 12, 2025 · 9114cf6 · 9114cf6
1 parent 74e84fb
commit 9114cf6
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 16 deletions.
diff --git a/.idea/inspectionProfiles/Project_Default.xml b/.idea/inspectionProfiles/Project_Default.xml
diff --git a/src/main/java/com/belellou/kevin/advent/year2015/Day19.java b/src/main/java/com/belellou/kevin/advent/year2015/Day19.java
@@ -47,10 +47,7 @@ private static void find(String medicine, String current, int currentIndex, Modi
                 if (newMedicine.equals(medicine)) {
                     System.out.println("Found");
                     throw new RuntimeException("Found");
-                } else if (newMedicine.length() > medicine.length()) {
-//                    System.out.println("Too long");
-                    // Do nothing
-                } else {
+                } else if (newMedicine.length() <= medicine.length()) {
                     int endIndex = newMedicine.length();
                     while (!medicine.startsWith(newMedicine.substring(0, endIndex))) {
                         endIndex--;
@@ -73,7 +70,7 @@ private static void find(String medicine, String current, int currentIndex, Modi
 //
 //                           String newCurrent =
 //                                   realCurrent.substring(0, localIndex) + s + realCurrent.substring(matchResult.end());
-////                           System.out.println(newCurrent);
+//                           System.out.println(newCurrent);
 //                           String newMedicine = prefix + newCurrent;
 //                           System.out.println("newMedicine: " + newMedicine);
 //

diff --git a/src/main/java/com/belellou/kevin/advent/year2015/Day24.java b/src/main/java/com/belellou/kevin/advent/year2015/Day24.java
@@ -15,14 +15,11 @@ private static void solve(List<Integer> packages, int index, int weightPerGroup,
 //                              AtomicLong currentSize,
                               AtomicLong minSize,
 //                              AtomicLong currentQuantum,
-                              AtomicLong minQuantum,
-                              List<Long> list) {
+                              AtomicLong minQuantum, List<Long> list) {
         for (int i = index - 1; i >= 0; i--) {
             int currentPackage = packages.get(i);
 
-            if (currentPackage > weightLeft) {
-                continue;
-            } else if (currentPackage == weightLeft) {
+            if (currentPackage == weightLeft) {
 //                long finalSize = currentSize.get() + 1;
 //                long finalQuantum = currentQuantum.get() * currentPackage;
                 list.add((long) currentPackage);
@@ -40,7 +37,7 @@ private static void solve(List<Integer> packages, int index, int weightPerGroup,
 
                 list.removeLast();
 //                return;
-            } else {
+            } else if (currentPackage < weightLeft) {
 //                currentSize.incrementAndGet();
 //                currentQuantum.set(currentQuantum.get() * currentPackage);
 

diff --git a/src/main/java/com/belellou/kevin/advent/year2016/Day17.java b/src/main/java/com/belellou/kevin/advent/year2016/Day17.java
@@ -17,7 +17,7 @@
 
 import com.belellou.kevin.advent.generic.AbstractDaySolver;
 
-@SuppressWarnings({"unused", "preview"})
+@SuppressWarnings({"unused"})
 public class Day17 extends AbstractDaySolver<String, Integer> {
 
     private static final Position startingPosition = Position.of(0, 0);

diff --git a/src/main/java/com/belellou/kevin/advent/year2016/Day21.java b/src/main/java/com/belellou/kevin/advent/year2016/Day21.java
@@ -38,9 +38,7 @@ private static String applyOperations(List<Operation> operations, boolean revers
 
         for (Operation operation : operations) {
             switch (operation.type) {
-                case SWAP_POSITION -> {
-                    ArrayUtils.swap(array, operation.firstOperand, operation.secondOperand);
-                }
+                case SWAP_POSITION -> ArrayUtils.swap(array, operation.firstOperand, operation.secondOperand);
                 case SWAP_LETTER -> {
                     int firstOperandIndex = getIndexedOf(array, operation.firstOperand);
                     int secondOperandIndex = getIndexedOf(array, operation.secondOperand);

diff --git a/src/main/java/com/belellou/kevin/advent/year2016/Day22.java b/src/main/java/com/belellou/kevin/advent/year2016/Day22.java
@@ -14,7 +14,7 @@
 import com.belellou.kevin.advent.generic.AbstractDaySolver;
 import com.belellou.kevin.advent.generic.DisableTest;
 
-@SuppressWarnings({"unused", "preview"})
+@SuppressWarnings({"unused"})
 public class Day22 extends AbstractDaySolver<Integer, Integer> {
 
     private static final String SPACE_DELIMITER_REGEX = "\\s+";