[14 Oct 2024] Drop python 3.8 support #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jairhenrique
force-pushed
the
drop-python38
branch
2 times, most recently
from
ba4e988
to
ea58e79
Compare
hartwork
reviewed
Jul 7, 2023
There was a problem hiding this comment.
@jairhenrique content looks good but I don't get the idea behind the "[06 Jun 2023]" prefix in the title. What's the idea?
|
@hartwork |
jairhenrique
changed the title
|
@jairhenrique that makes more sense now. Do we really want to have a pull request hang around for that long though? It may need constant rebasing for nothing, long-lived pull request are rarely healthy. |
jairhenrique
force-pushed
the
drop-python38
branch
from
ea58e79
to
ce254d8
Compare
|
@hartwork This PR is a draft and I'd rather deal with small jobs than leave a big job for last. I'll keep this as a draft without too much "pressure". |
|
@jairhenrique if it works for you I'm good, okay. |
jairhenrique
force-pushed
the
drop-python38
branch
4 times, most recently
from
acc3d21
to
27b10ef
Compare
jairhenrique
force-pushed
the
drop-python38
branch
from
27b10ef
to
80d591a
Compare
jairhenrique
force-pushed
the
drop-python38
branch
5 times, most recently
from
3a5e79d
to
73eb933
Compare
hartwork
requested changes
Oct 12, 2024
There was a problem hiding this comment.
@jairhenrique thanks for the adjustments, looks 99% ready to merge to me. Two details below:
jairhenrique
force-pushed
the
drop-python38
branch
from
73eb933
to
8634bde
Compare
jairhenrique
force-pushed
the
drop-python38
branch
from
8634bde
to
ab8944d
Compare
hartwork
approved these changes
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.