Fix ResourceWarning unclosed socket #758
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #710 by properly closing the underlying socket. It first uses
pool._put_conn
to keep the connection in the pool, and later removes and closes it when the context manager exits.I was unsure about the exact purpose of the
ConnectonRemove
class, so I made minimal changes to minimize the risk of breaking the code and there may be better solutions for fixing this issue.For example, the
urllib3.connectionpool.HTTPConnectionPool
will utilize a weakref to terminate pool connections. By appending our connection to it, it will also take care of closing our connection. So another solution could be to modify the__exit__
inpatch.ConnectionRemover
method and add our connection to the pool: