-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish up on Python 3.12 support #775
Conversation
blocked by kevin1024/vcrpy#775
@hartwork can you rebase with master!? |
@jairhenrique sure, but it had little chance of working (with regard to red CI) last time, hence the draft. Rebased and pushed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #775 +/- ##
=======================================
Coverage 90.10% 90.10%
=======================================
Files 27 27
Lines 1809 1809
Branches 335 335
=======================================
Hits 1630 1630
Misses 134 134
Partials 45 45 ☔ View full report in Codecov by Sentry. |
@jairhenrique I have re-run the pypy3.10 CI 10 times now without a single success. I believe it's time to declare that support broken and drop it in a dedicated pull request, coming up in a minute. The errors were: a) with
b) with
|
a4aeca2
to
954a100
Compare
@jairhenrique now that this is merged, I'll write an issue recommending a new release to unblock users' upgrade to Python 3.12. Will take a few minutes. |
Follow-up to #754