Draft
Conversation
Collaborator
|
Big 👍 for splitting |
cavasinf
reviewed
Apr 26, 2024
Comment on lines
45
to
+51
| icons: | ||
| # used for the action_collapsebutton components | ||
| collapse: fas fa-chevron-down | ||
| collapse: "fa6-solid:chevron-down" | ||
| # used for the password-reset template | ||
| mail: far fa-envelope | ||
| mail: "fa6-regular:envelope" | ||
| # used for the 404/500/... error page | ||
| back: fas fa-long-arrow-alt-left | ||
| back: "fa6-solid:left-long" |
Collaborator
There was a problem hiding this comment.
Do we still keep the icons config part in the future, or just during the temporary "deprecated" period?
Owner
Author
There was a problem hiding this comment.
Keep it during the deprecation period. I want to try to make this PR completely BC safe.
Owner
Author
There was a problem hiding this comment.
On the other hand, this is a tiny layer on top of the UX icons later, that helps managing and downloading them.
Not sure yet ...
kevinpapst
commented
Jul 5, 2024
| return $this->iconRenderer->renderIcon($icon, ['class' => 'icon']); | ||
| } | ||
|
|
||
| @trigger_error('Support for webfonts is deprecated. Switch to UX icons. Using twig function tabler_icon("' . $name . '") is deprecated.', \E_USER_DEPRECATED); |
Owner
Author
There was a problem hiding this comment.
Suggested change
| @trigger_error('Support for webfonts is deprecated. Switch to UX icons. Using twig function tabler_icon("' . $name . '") is deprecated.', \E_USER_DEPRECATED); | |
| @trigger_error('Using twig function tabler_icon("' . $name . '") without an iconify identifier is deprecated, see https://github.com/kevinpapst/TablerBundle/pull/195.', \E_USER_DEPRECATED); |
Collaborator
|
Will this be in |
Owner
Author
|
I haven't worked on that since creating the PR, so I don't know. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a first draft for UX icons integration.
It supports both Fontawesome webfont and UX icons.
It ships a command that can convert current webfont configuration and download all icons configured at
tabler.icons, and it even supports converting old FA5 to FA6 names (the webfont supported both versions, iconify only the new names).The
tabler_icon()Twig functions works as before and supports both implementations.The
|tabler_iconTwig filter will still work with webfonts, but not with UX icons.The biggest issues I see:
Closes #194
Types of changes
Checklist