Skip to content

[Addons] Add flags + payments#251

Open
cavasinf wants to merge 2 commits intokevinpapst:mainfrom
TeamAllsoftware:addons
Open

[Addons] Add flags + payments#251
cavasinf wants to merge 2 commits intokevinpapst:mainfrom
TeamAllsoftware:addons

Conversation

@cavasinf
Copy link
Collaborator

Description

Add flags + payments in public folder

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I updated the documentation (see here)
  • I agree that this code will be published under the MIT license

@cavasinf cavasinf self-assigned this Jan 19, 2026
@cavasinf cavasinf added Status: Needs Review Not under investigation Feature Feature requested labels Jan 19, 2026
@cavasinf cavasinf added this to the 2.1 milestone Jan 19, 2026
@cavasinf
Copy link
Collaborator Author

@kevinpapst I don’t know why the tabler and tabler-rtl files changed when I built the project.

Should we keep these changes in this PR, or should I revert them?

@cavasinf cavasinf marked this pull request as ready for review January 19, 2026 11:36
@kevinpapst
Copy link
Owner

Why shall we commit the icons here?
In that case we should/could integrate the tabler icons as well.
I think we should stop shipping FontAwesome and not ship third party image/icon font files altogether.

We can help with prepared CSS files, that's okay.
And then document how to use them.
But I don't want to ship single icon packages with this bundle.
It's so opinionated.

We should probably check how to integrate those into the list of https://ux.symfony.com/icons - might be much easier, once the ux_icons stuff is merged

@cavasinf
Copy link
Collaborator Author

Why shall we commit the icons here?

Icons come from node_modules/@tabler/core/dist/img/payments https://github.com/tabler/tabler/tree/dev/core/img.
As node_modules is not present on production, these assets must be copied into the project.

During yarn build, Webpack copies required images into public/... (Referencing Images with Webpack Encore) and updates the asset manifest
to reference versioned files (cache busting).
These files are build artifacts generated by yarn build, not manually added files.
If they are not committed, production will miss them.

I do not think something is wrong here from a project perspective, but it may be questionable from a bundle perspective? 🤔

In that case we should/could integrate the tabler icons as well.

I both agree and disagree 😅. We should, because we are sticking to the Tabler theme, so Tabler icons are a logical choice.
However, this is limiting in terms of icon choice and custom icon integration. It is also harder to
implement them with raw HTML (without webfont due to this .icon class that don't work well without <svg>).

IMO, Symfony UX Icons are much more flexible in that regard, and they also support twig function AND aliases, like tabler_icon did before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Feature requested Status: Needs Review Not under investigation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants