Add symfonycasts/reset-password-bundle@1.11 template#53
Add symfonycasts/reset-password-bundle@1.11 template#53cavasinf wants to merge 35 commits intokevinpapst:mainfrom
symfonycasts/reset-password-bundle@1.11 template#53Conversation
|
@kevinpapst How do you generate your trads file in the Bundle ?
|
@kevinpapst Any answer of that? |
Co-authored-by: Kevin Papst <kevinpapst@users.noreply.github.com>
|
Never used that command I guess. I always create translation files while developing views. |
|
Missing translations ! |
cavasinf
left a comment
There was a problem hiding this comment.
Added FR translation.
@kevinpapst It is ready for me, do you want to add the German translation ?
kevinpapst
left a comment
There was a problem hiding this comment.
- Can you link the docs page from the docs index
_layout.html.twigdoes not match any filename convention?check_email.html.twigshould becheck-email.html.twigbecuase all files included directly by the controller should be x-y.html.twig - correct?- Add a composer suggest for the package
|
Can you please include these german / DE translations: <trans-unit id="948fezF" resname="Password Reset Email Sent">
<source>Password Reset Email Sent</source>
<target>E-Mail für die Zurücksetzung des Passwort wurde gesendet</target>
</trans-unit>
<trans-unit id="5FE896d" resname="Enter your email address and your password will be reset and emailed to you">
<source>Enter your email address and your password will be reset and emailed to you</source>
<target>Geben Sie Ihre E-Mail Adresse an und Sie bekommen eine Nachricht um Ihr Passwort zurückzusetzen</target>
</trans-unit>
<trans-unit id="RG984sg" resname="If an account matching your email exists, then an email was just sent that contains a link that you can use to reset your password. This link will expire in %token%.">
<source>If an account matching your email exists, then an email was just sent that contains a link that you can use to reset your password. This link will expire in %token%.</source>
<target>Wenn ein Zugang mit Ihrer E-Mail existiert, wurde soeben eine E-Mail dorthin versendet, welche eine Link beinhaltet, mit dem Sie Ihr Passwort zurücksetzen können. Dieser Link wird ablaufen in %token%.</target>
</trans-unit>
<trans-unit id="498fEsz" resname="If you don't receive an email please check your spam folder or">
<source>If you don't receive an email please check your spam folder or</source>
<target>Wenn Sie keine E-Mail erhalten, überprüfen Sie bitte Ihren Spam Ordner oder/target>
</trans-unit>
<trans-unit id="EF54d5d" resname="Try again">
<source>Try again</source>
<target>Versuchen Sie es erneut</target>
</trans-unit> |
|
|
Good to go 👍 |
removed deprecation, template is still used
kevinpapst
left a comment
There was a problem hiding this comment.
I removed the deprecation, because the "legacy" template is still used.
I will not maintain this part of the bundle, but I am okay merging it.
Description
From #10
More here: https://github.com/SymfonyCasts/reset-password-bundle
Types of changes
Checklist