-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding docker part and isolated muon example #68
base: main
Are you sure you want to change the base?
Conversation
Thanks! You could save some bytes in the docker image by removing the build folders after installing - they don't need to be distributed in the image, right? |
Good point! Let me try |
Done. I have saved like 300MB. |
I think the notebook would benefit from a plain text description what it is doing and the plots from some axis labels. In general plain markdown files are nicer to use with version control and can be converted to notebooks with tools like jupytext, see what we are doing here: https://github.com/key4hep/k4MarlinWrapper/blob/master/doc/starterkit/k4MarlinWrapperCLIC/Readme.md Just out of curiosity: Why use |
Hi Valentin, Sounds good to me. I have converted it. Regarding singularity shell docker://ilcsoft/k4simdelphes:latest as this will pull the image and unpack it in your working directory. This takes like 30min. Of course, it's fast after caching. More information is |
Hi @vvolkl and @tmadlener |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @EnginEren,
sorry for the delay. I have a few minor comments about some details.
BEGINRELEASENOTES
ENDRELEASENOTES