Skip to content
This repository was archived by the owner on Jan 24, 2025. It is now read-only.

Test Vector Generation works again #35

Closed
gallizoltan wants to merge 25 commits into from
Closed

Test Vector Generation works again #35

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
6026f6e
Added bip39 seed and bip39 mnemonic fields
TechyShishy Jan 21, 2017
e9fd138
v1.0.9 Update generated build files for bip39 code
TechyShishy Jan 21, 2017
523dd41
makefile use bash instead of sh
Jul 25, 2018
8494527
README update
Jul 25, 2018
f330ceb
bu becomes ku
Jul 25, 2018
7be707a
pycoin's ku syntax changed
Jul 25, 2018
e5cb4f8
bip39 mnemonic for HD wallets #1
Jul 26, 2018
89c158f
Merge pull request #1 from Shishire/master
gallizoltan Jul 26, 2018
9b7d422
README update: install bitcore-mnemonic
Jul 26, 2018
129c565
Merge branch 'mnemonic' of https://github.com/gallizoltan/warpwallet …
Jul 26, 2018
f20e69a
BIP39 Reference Implementation
Jul 26, 2018
215acf1
bitcore-mnemonic files
Jul 26, 2018
2951bf0
Revert "README update: install bitcore-mnemonic"
Jul 26, 2018
1a2030e
mnemonics added to test suite
Jul 26, 2018
5c3950b
Update to latest BIP39 Reference Implementation
Jul 26, 2018
a87cc86
using all 32 bytes of seed for mnemonic
Jul 26, 2018
0d4a994
Regeneration of Test Vectors to include mnemonics
Jul 26, 2018
d3c9672
mnemonic check included in test
Jul 26, 2018
9936736
bip39-mnemonic field is a textarea
Jul 27, 2018
f6ac204
version number increase
Jul 27, 2018
e1c7eaf
Merge pull request #2 from gallizoltan/mnemonic
gallizoltan Jul 27, 2018
409bd3d
Test Vector version number increase
Jul 27, 2018
ba5a9e9
generated file update
Jul 27, 2018
bf65f7a
incompatible 1.0.9 generated file removal
Jul 27, 2018
3a18600
mention pbkdf2 in README.md
Jul 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ it does use npm to manage its dependencies
## Build

```sh
$ npm install -g iced-coffee-script
$ sudo ln -s /usr/bin/nodejs /usr/bin/node
Copy link
Contributor

@maxtaco maxtaco Jul 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove these changes? I'm assuming you've installed node as your user and it's in your path.

Copy link
Author

@gallizoltan gallizoltan Jul 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I will remove this.

$ sudo npm install -g iced-coffee-script
$ npm install -d
$ icake build
```
Expand All @@ -27,6 +28,8 @@ To generate our reference test vectors, we use the reference Scrypt implementati
Python PBKDF2, and a Python library to turn a seed into a keypair. To see how this works, try:

```sh
$ pip install virtualenv
$ sudo /usr/bin/easy_install virtualenv
Copy link
Contributor

@maxtaco maxtaco Jul 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this line needed?

Copy link
Author

@gallizoltan gallizoltan Jul 27, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed only at the first run.

$ cd test/gen && make build && make spec
```

Expand Down
5 changes: 3 additions & 2 deletions test/gen/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@

SHELL := /bin/bash
Copy link
Contributor

@maxtaco maxtaco Jul 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this needed? I use sh

Copy link
Author

@gallizoltan gallizoltan Jul 27, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this the make build fails with this message:

/bin/sh: 1: source: not found
Makefile:15: recipe for target 'build-python' failed
make: *** [build-python] Error 127

I googled for "/bin/sh: 1: source: not found" and found this solution:
https://stackoverflow.com/questions/670191/getting-a-source-not-found-error-when-using-source-in-a-bash-script

I don'n know, I have a Ubuntu 16.04 LTS. What environment are you using for sh to find source?

SCRYPT_DIR=../../node_modules/triplesec/contrib/scrypt-1.1.6
SCRYPT=${SCRYPT_DIR}/scrypt
PBKDF2=./pbkdf2.py
BU=py-venv/bin/bu
KU=py-venv/bin/ku

build: build-scrypt build-python

Expand All @@ -17,6 +18,6 @@ input:
iced gen_input.iced > input.json

spec:
(source py-venv/bin/activate && iced gen_spec.iced ${SCRYPT} ${PBKDF2} ${BU} > ../spec.json)
(source py-venv/bin/activate && iced gen_spec.iced ${SCRYPT} ${PBKDF2} ${KU} > ../spec.json)

.PHONY: build-scrypt build-python build
10 changes: 5 additions & 5 deletions test/gen/gen_spec.iced
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,14 +105,14 @@ class Runner
for line in out.join("\n").split(/\n+/) when line.length
[key,val] = line.split(/:\s+/)
if key[0] is ' '
bu_out[last_key][key.replace(/\s+/, '')] = val
bu_out[last_key][key.replace(/^\s+|\s+$/g, '')] = val
else
last_key = key
bu_out[key] = { _ : val}
last_key = key.replace(/\s+$/, '')
bu_out[last_key] = { "value" : val}

cb {
"private" : bu_out.WIF.uncompressed
"public" : bu_out['Bitcoin address'].uncompressed
"private" : bu_out.wif.uncompressed
"public" : bu_out['Bitcoin address uncompressed'].value
}

#-------------------
Expand Down