change(mac): remove verbose logging option #12431
Merged
+55
−214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also remove related debug mode code, debug logging is controlled solely by universal logging settings Fixes: #11525
keymanapp-test-bot
bot
added
the
user-test-missing
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
|
CI build failed with build:testapp starting...
08:59:58 /.../keyman/mac/Keyman4Mac/Keyman4Mac/AppDelegate.m:230:11: error: use of undeclared identifier 'debugMode'
08:59:58 if (debugMode) { |
keymanapp-test-bot
bot
removed
the
user-test-missing
darcywong00
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
lgtm
We'll also need to update the in-app help
https://help.keyman.com/products/mac/18.0/basic/config/options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Options tab of the Configuration window, removed the checkbox titled 'Use verbose Console logging'.
Also remove code related to debug mode. Instead of using the verbose logging option to determine whether we are in debug mode or not, write to the log based solely on the unified logging settings for Keyman. This change follows naturally from #11515.
Because the related UserDefaults setting is retired, introduce a new UserDefaults flag with a narrower scope to force a sentry crash for testing purposes. The key for this flag is "KMForceSentryError". It is not tied to any UI but can be set manually from the command line if needed for testing purposes.
Fixes: #11525
@keymanapp-test-bot skip