chore(common): Allow to build offline #12439
Open
+33
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
ermshiperete
force-pushed
the
chore/common/offline
branch
from
de980f4
to
c12f788
Compare
A lot of the `configure` actions rely on node dependencies and so call `npm install`. Without a internet connection this hangs forever, even if you had successfully installed the dependencies before and nothing changed since then. This change adds a `--offline` parameter that passes `--prefer-offline` to npm, which causes npm to use the cached dependencies. Also sets the `MESON_PACKAGE_CACHE_DIR` environment variable so that all (sub-)projects share the same package cache dir. This will speed up regular builds a bit (e.g. `developer/src/kmcmplib` and `core` both have `icu4c` as a dependency), but will also help with offline builds. `MESON_PACKAGE_CACHE_DIR` requires Meson 1.3, however older Meson versions ignore this environment variable and simply continue to use a cache per subproject, so will continue to work (minus offline builds).
ermshiperete
force-pushed
the
chore/common/offline
branch
from
c12f788
to
389fb4f
Compare
ermshiperete
commented
Sep 18, 2024
| builder_echo "Trying offline build" | ||
| offline_param=--prefer-offline | ||
| fi | ||
| try_multiple_times npm ${offline_param} ci |
There was a problem hiding this comment.
We could consider to always pass --prefer-offline which would probably help if nodejs.org has an outage, but I don't know if that has unwanted side-effects.
There was a problem hiding this comment.
I don't know if that's a good idea for build agents?
mcdurdin
approved these changes
Sep 19, 2024
|
|
||
| # Set shared Meson package cache (works with Meson >= 1.3) | ||
| if [[ -z ${MESON_PACKAGE_CACHE_DIR:-} ]]; then | ||
| export MESON_PACKAGE_CACHE_DIR="${XDG_CACHE_HOME:-${HOME}/.cache}/keyman/builder" |
There was a problem hiding this comment.
Is ~/.cache a safe path? We have already a ~/.keyman path used for nvm (see
Line 33 in aa50672
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of the
configureactions rely on node dependencies and so callnpm install. Without a internet connection this hangs forever, even if you had successfully installed the dependencies before and nothing changed since then. This change adds a--offlineparameter that passes--prefer-offlineto npm, which causes npm to use the cached dependencies.Also sets the
MESON_PACKAGE_CACHE_DIRenvironment variable so that all (sub-)projects share the same package cache dir. This will speed up regular builds a bit (e.g.developer/src/kmcmplibandcoreboth haveicu4cas a dependency), but will also help with offline builds.MESON_PACKAGE_CACHE_DIRrequires Meson 1.3, however older Meson versions ignore this environment variable and simply continue to use a cache per subproject, so will continue to work (minus offline builds).@keymanapp-test-bot skip