-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(linux): add newest changes from mnemonic layout support-mac to mnemonic layout support-linux 🐘 #12444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keymanapp-test-bot
bot
added
the
user-test-missing
User tests have not yet been defined for the PR
label
Sep 19, 2024
User Test ResultsTest specification and instructions User tests are not required Test Artifacts |
keymanapp-test-bot
bot
changed the title
feature(linux): add newest changes from mnemonic layout support-mac to mnemonic layout support-linux 🐘
feature(linux): add newest changes from mnemonic layout support-mac to mnemonic layout support-linux 🐘 🐘
Sep 19, 2024
SabineSIL
removed
the
user-test-missing
User tests have not yet been defined for the PR
label
Sep 19, 2024
SabineSIL
changed the title
feature(linux): add newest changes from mnemonic layout support-mac to mnemonic layout support-linux 🐘 🐘
feature(linux): add newest changes from mnemonic layout support-mac to mnemonic layout support-linux 🐘
Sep 19, 2024
keymanapp-test-bot
bot
changed the title
feature(linux): add newest changes from mnemonic layout support-mac to mnemonic layout support-linux 🐘
feature(linux): add newest changes from mnemonic layout support-mac to mnemonic layout support-linux 🐘 🐘
Sep 19, 2024
SabineSIL
changed the title
feature(linux): add newest changes from mnemonic layout support-mac to mnemonic layout support-linux 🐘 🐘
feature(linux): add newest changes from mnemonic layout support-mac to mnemonic layout support-linux :elephant
Sep 19, 2024
keymanapp-test-bot
bot
changed the title
feature(linux): add newest changes from mnemonic layout support-mac to mnemonic layout support-linux :elephant
feature(linux): add newest changes from mnemonic layout support-mac to mnemonic layout support-linux :elephant 🐘
Sep 19, 2024
SabineSIL
changed the title
feature(linux): add newest changes from mnemonic layout support-mac to mnemonic layout support-linux :elephant 🐘
feature(linux): add newest changes from mnemonic layout support-mac to mnemonic layout support-linux 🐘
Sep 19, 2024
keymanapp-test-bot
bot
changed the title
feature(linux): add newest changes from mnemonic layout support-mac to mnemonic layout support-linux 🐘
feature(linux): add newest changes from mnemonic layout support-mac to mnemonic layout support-linux 🐘 🐘
Sep 19, 2024
SabineSIL
changed the title
feature(linux): add newest changes from mnemonic layout support-mac to mnemonic layout support-linux 🐘 🐘
feature(linux): add newest changes from mnemonic layout support-mac to mnemonic layout support-linux
Sep 19, 2024
keymanapp-test-bot
bot
changed the title
feature(linux): add newest changes from mnemonic layout support-mac to mnemonic layout support-linux
feature(linux): add newest changes from mnemonic layout support-mac to mnemonic layout support-linux 🐘
Sep 19, 2024
SabineSIL
requested review from
ermshiperete and
darcywong00
as code owners
September 19, 2024 09:30
ermshiperete
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@SabineSIL You should merge/rebase your branch with |
…inux/mcompile-PR_11334
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #11334
see #9384
after finishing requested changes for PR #11334 (mnemonic layout support-mac) relevant changes have been added to mnemonic layout support-linux as well.
@keymanapp-test-bot skip