Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(linux): add newest changes from mnemonic layout support-mac to mnemonic layout support-linux 🐘 #12444

Merged
merged 4 commits into from
Sep 30, 2024

Conversation

SabineSIL
Copy link
Contributor

@SabineSIL SabineSIL commented Sep 19, 2024

see #11334
see #9384

after finishing requested changes for PR #11334 (mnemonic layout support-mac) relevant changes have been added to mnemonic layout support-linux as well.

@keymanapp-test-bot skip

@SabineSIL SabineSIL added this to the A18S11 milestone Sep 19, 2024
@SabineSIL SabineSIL self-assigned this Sep 19, 2024
@keymanapp-test-bot keymanapp-test-bot bot added the user-test-missing User tests have not yet been defined for the PR label Sep 19, 2024
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Sep 19, 2024

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot changed the title feature(linux): add newest changes from mnemonic layout support-mac to mnemonic layout support-linux 🐘 feature(linux): add newest changes from mnemonic layout support-mac to mnemonic layout support-linux 🐘 🐘 Sep 19, 2024
@SabineSIL SabineSIL removed the user-test-missing User tests have not yet been defined for the PR label Sep 19, 2024
@SabineSIL SabineSIL changed the title feature(linux): add newest changes from mnemonic layout support-mac to mnemonic layout support-linux 🐘 🐘 feature(linux): add newest changes from mnemonic layout support-mac to mnemonic layout support-linux 🐘 Sep 19, 2024
@keymanapp-test-bot keymanapp-test-bot bot changed the title feature(linux): add newest changes from mnemonic layout support-mac to mnemonic layout support-linux 🐘 feature(linux): add newest changes from mnemonic layout support-mac to mnemonic layout support-linux 🐘 🐘 Sep 19, 2024
@SabineSIL SabineSIL changed the title feature(linux): add newest changes from mnemonic layout support-mac to mnemonic layout support-linux 🐘 🐘 feature(linux): add newest changes from mnemonic layout support-mac to mnemonic layout support-linux :elephant Sep 19, 2024
@keymanapp-test-bot keymanapp-test-bot bot changed the title feature(linux): add newest changes from mnemonic layout support-mac to mnemonic layout support-linux :elephant feature(linux): add newest changes from mnemonic layout support-mac to mnemonic layout support-linux :elephant 🐘 Sep 19, 2024
@SabineSIL SabineSIL changed the title feature(linux): add newest changes from mnemonic layout support-mac to mnemonic layout support-linux :elephant 🐘 feature(linux): add newest changes from mnemonic layout support-mac to mnemonic layout support-linux 🐘 Sep 19, 2024
@keymanapp-test-bot keymanapp-test-bot bot changed the title feature(linux): add newest changes from mnemonic layout support-mac to mnemonic layout support-linux 🐘 feature(linux): add newest changes from mnemonic layout support-mac to mnemonic layout support-linux 🐘 🐘 Sep 19, 2024
@SabineSIL SabineSIL changed the title feature(linux): add newest changes from mnemonic layout support-mac to mnemonic layout support-linux 🐘 🐘 feature(linux): add newest changes from mnemonic layout support-mac to mnemonic layout support-linux Sep 19, 2024
@keymanapp-test-bot keymanapp-test-bot bot changed the title feature(linux): add newest changes from mnemonic layout support-mac to mnemonic layout support-linux feature(linux): add newest changes from mnemonic layout support-mac to mnemonic layout support-linux 🐘 Sep 19, 2024
@SabineSIL SabineSIL marked this pull request as ready for review September 19, 2024 09:30
Copy link
Contributor

@ermshiperete ermshiperete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ermshiperete
Copy link
Contributor

@SabineSIL You should merge/rebase your branch with origin/epic/linux-mcompile then it'll build on Linux.

@darcywong00 darcywong00 modified the milestones: A18S11, A18S12 Sep 28, 2024
@SabineSIL SabineSIL merged commit d8716d8 into epic/linux-mcompile Sep 30, 2024
7 of 8 checks passed
@SabineSIL SabineSIL deleted the feat/linux/mcompile-PR_11334 branch September 30, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants