Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(developer): generator from regression to JSON format 🙀 #13098

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

feat(developer): generator from regression to JSON format 🙀 #13098

wants to merge 4 commits into from
+209 −9

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Jan 30, 2025 •
edited
Loading

This adds a command to kmc as below:

kmc build ldml-regression-test --keyboard experimental/k/khmer_ldml/source/khmer_ldml.xml release/k/khmer_angkor/extras/regression_tests/

The command generates experimental/k/khmer_ldml/source/khmer_ldml-test.json in the same format as the kmc build ldml-test-data command outputs, and which the ldml unit test reads.

The user then can rename that file to experimental/k/khmer_ldml/build/khmer_ldml-test.json (because, the test file must be colocated with the .kmx) and then the ldml tool can be used to execute it as a unit test.

For: #10192

@keymanapp-test-bot skip

srl295 added 2 commits January 30, 2025 14:29
@srl295
fix(core): fix ldml.cpp to use wcout instead of cerr so that test fai…
545d0fb 
…lures show up on linux console

For: #10192
@srl295
feat(developer): generator from keyman developer 'regression test' fo…
568c374 
…rmat into .json

- reads the regression test format such as the khmer_angkor keyboard has
- outputs into the -test.json format which is read by the 'ldml' unit test case

#10192
@srl295 srl295 requested a review from Nnyny January 30, 2025 20:42
@keymanapp-test-bot keymanapp-test-bot bot added the user-test-missing User tests have not yet been defined for the PR label Jan 30, 2025
@srl295 srl295 self-assigned this Jan 30, 2025
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Jan 30, 2025 •
edited
Loading

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S20 milestone Jan 30, 2025
@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-missing User tests have not yet been defined for the PR label Jan 30, 2025
@darcywong00 darcywong00 modified the milestones: A18S20, B18S1 Feb 1, 2025
@darcywong00 darcywong00 modified the milestones: B18S1, B18S2 Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nnyny Nnyny Awaiting requested review from Nnyny

@mcdurdin mcdurdin Awaiting requested review from mcdurdin mcdurdin will be requested when the pull request is marked ready for review mcdurdin is a code owner

@darcywong00 darcywong00 Awaiting requested review from darcywong00 darcywong00 will be requested when the pull request is marked ready for review darcywong00 is a code owner

@SabineSIL SabineSIL Awaiting requested review from SabineSIL SabineSIL will be requested when the pull request is marked ready for review SabineSIL is a code owner

@markcsinclair markcsinclair Awaiting requested review from markcsinclair markcsinclair will be requested when the pull request is marked ready for review markcsinclair is a code owner

@rc-swag rc-swag Awaiting requested review from rc-swag rc-swag will be requested when the pull request is marked ready for review rc-swag is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@srl295 srl295

Labels
core/ Keyman Core developer/compilers/ developer/ feat
Projects
Keyman
Status: No status
Milestone
B18S2
Development

Successfully merging this pull request may close these issues.
3 participants
@srl295 @mcdurdin @darcywong00