Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): output keyman_core_ldml.sh #13252

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat(core): output keyman_core_ldml.sh #13252

wants to merge 1 commit into from
+82 −37

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Feb 14, 2025

  • refactor const generator
  • output as .sh also
  • use variable instead of fixed 46

Split out from #13236

@keymanapp-test-bot skip

@srl295
feat(core): output keyman_core_ldml.sh
4b33912 
- refactor const generator
- output as .sh also
- use variable instead of fixed 46
@srl295 srl295 self-assigned this Feb 14, 2025
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Feb 14, 2025 •
edited
Loading

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot added this to the B18S1 milestone Feb 14, 2025
@srl295 srl295 mentioned this pull request Feb 14, 2025
Merged
@srl295
Copy link
Member Author

srl295 commented Feb 14, 2025

To quote @mcdurdin

For 19.0, let's try and avoid the common->core dependency direction by moving this header and friends into /common/include/ldml.

It's better for core to depend on common than the other way around.

It may be cleaner to do that before this PR lands?

See:

@srl295 srl295 modified the milestones: B18S1, B18S2 Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jahorton jahorton Awaiting requested review from jahorton jahorton will be requested when the pull request is marked ready for review jahorton is a code owner

@mcdurdin mcdurdin Awaiting requested review from mcdurdin mcdurdin will be requested when the pull request is marked ready for review mcdurdin is a code owner

@rc-swag rc-swag Awaiting requested review from rc-swag rc-swag will be requested when the pull request is marked ready for review rc-swag is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@srl295 srl295

Labels
common/web/ common/ core/ Keyman Core feat
Projects
Keyman
Status: No status
Milestone
B18S2
Development

Successfully merging this pull request may close these issues.
1 participant
@srl295