fix(web): properly support workerless use of Web engine #13290
+78
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #13262 Fixes: KEYMANWEB-COM-1VH
keymanapp-test-bot
bot
added
has-user-test
user-test-required
User Test ResultsTest specification and instructions Test Artifacts
|
Test ResultsI tested this issue with the attached Keyman"18.0.197-beta-test-13290" build(20/02/2025) on Android 14(Physical device). Here I am sharing my observation.
|
keymanapp-test-bot
bot
removed
the
user-test-required
mcdurdin
approved these changes
Feb 21, 2025
Comment on lines
+45
to
+49
| try { | ||
| this.lmEngine = new LMLayer(capabilities, predictiveWorkerFactory?.constructInstance()); | ||
| } catch { | ||
| // We can condition on `lmEngine` being null/undefined. | ||
| } |
There was a problem hiding this comment.
Ideally the try/catch would be around constructInstance() only, not around new LMLayer. Even then, if there is an error in the constructor apart from the WebWorker not being available, the catchall is going to mask the error completely. Hence, I think we should console.warn() on it (not sure my suggestion is perfect here).
Suggested change
| try { | |
| this.lmEngine = new LMLayer(capabilities, predictiveWorkerFactory?.constructInstance()); | |
| } catch { | |
| // We can condition on `lmEngine` being null/undefined. | |
| } | |
| let instance: <TypeHere>; | |
| try { | |
| instance = predictiveWorkerFactory?.constructInstance(); | |
| } catch(e) { | |
| // We can condition on `lmEngine` being null/undefined. | |
| console.warn('Web workers are not available: ' + (e ?? '').toString()); | |
| instance = null; | |
| } | |
| if(instance) { | |
| this.lmEngine = new LMLayer(capabilities, instance); | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #13262
Fixes: KEYMANWEB-COM-1VH
Supersedes: #13270.
User Testing
TEST_ANDROID_PREDICTIONS: Using the Keyman for Android test artifact, verify that predictive text appears to function as usual.