fix: localization + dynamic replacement options not saving

khcrysalis · Jan 30, 2025 · 6ca9832 · 6ca9832
1 parent 4c8faf9
commit 6ca9832
Show file tree

Hide file tree

Showing 8 changed files with 24 additions and 8 deletions.
diff --git a/Shared/Localizations/de.lproj/Localizable.strings b/Shared/Localizations/de.lproj/Localizable.strings
@@ -232,7 +232,7 @@
 "APP_SIGNING_INPUT_VIEW_CONTROLLER_REMOVE_FORCE_PRO_MOTION_DESCRIPTION" = "Enables ProMotion capabilities within the app, however on lower versions of 15.x this may not be enough.";
 
 "APP_SIGNING_INPUT_VIEW_CONTROLLER_REMOVE_FORCE_GAME_MODE" = "Force Game Mode";
-"APP_SIGNING_INPUT_VIEW_CONTROLLER_REMOVE_FORCE_PRO_MOTION_DESCRIPTION" = "Enables Game Mode within the app, minimizing background activity and prioritized performance for the app.";
+"APP_SIGNING_INPUT_VIEW_CONTROLLER_REMOVE_FORCE_GAME_MODE_DESCRIPTION" = "Enables Game Mode within the app, minimizing background activity and prioritized performance for the app.";
 
 "APP_SIGNING_INPUT_VIEW_CONTROLLER_REMOVE_FORCE_FULLSCREEN" = "Force Fullscreen";
 "APP_SIGNING_INPUT_VIEW_CONTROLLER_REMOVE_FORCE_FULLSCREEN_DESCRIPTION" = "Forces only fullscreen capabilities within iPad apps, disallowing sharing the screen with other apps. On an external screen, the window for an app with this setting maintains its canvas size.";

diff --git a/Shared/Localizations/en.lproj/Localizable.strings b/Shared/Localizations/en.lproj/Localizable.strings
@@ -235,7 +235,7 @@
 "APP_SIGNING_INPUT_VIEW_CONTROLLER_REMOVE_FORCE_PRO_MOTION_DESCRIPTION" = "Enables ProMotion capabilities within the app, however on lower versions of 15.x this may not be enough.";
 
 "APP_SIGNING_INPUT_VIEW_CONTROLLER_REMOVE_FORCE_GAME_MODE" = "Force Game Mode";
-"APP_SIGNING_INPUT_VIEW_CONTROLLER_REMOVE_FORCE_PRO_MOTION_DESCRIPTION" = "Enables Game Mode within the app, minimizing background activity and prioritized performance for the app.";
+"APP_SIGNING_INPUT_VIEW_CONTROLLER_REMOVE_FORCE_GAME_MODE_DESCRIPTION" = "Enables Game Mode within the app, minimizing background activity and prioritized performance for the app.";
 
 "APP_SIGNING_INPUT_VIEW_CONTROLLER_REMOVE_FORCE_FULLSCREEN" = "Force Fullscreen";
 "APP_SIGNING_INPUT_VIEW_CONTROLLER_REMOVE_FORCE_FULLSCREEN_DESCRIPTION" = "Forces only fullscreen capabilities within iPad apps, disallowing sharing the screen with other apps. On an external screen, the window for an app with this setting maintains its canvas size.";

diff --git a/Shared/Localizations/es.lproj/Localizable.strings b/Shared/Localizations/es.lproj/Localizable.strings
@@ -232,7 +232,7 @@
 "APP_SIGNING_INPUT_VIEW_CONTROLLER_REMOVE_FORCE_PRO_MOTION_DESCRIPTION" = "Enables ProMotion capabilities within the app, however on lower versions of 15.x this may not be enough.";
 
 "APP_SIGNING_INPUT_VIEW_CONTROLLER_REMOVE_FORCE_GAME_MODE" = "Force Game Mode";
-"APP_SIGNING_INPUT_VIEW_CONTROLLER_REMOVE_FORCE_PRO_MOTION_DESCRIPTION" = "Enables Game Mode within the app, minimizing background activity and prioritized performance for the app.";
+"APP_SIGNING_INPUT_VIEW_CONTROLLER_REMOVE_FORCE_GAME_MODE_DESCRIPTION" = "Enables Game Mode within the app, minimizing background activity and prioritized performance for the app.";
 
 "APP_SIGNING_INPUT_VIEW_CONTROLLER_REMOVE_FORCE_FULLSCREEN" = "Force Fullscreen";
 "APP_SIGNING_INPUT_VIEW_CONTROLLER_REMOVE_FORCE_FULLSCREEN_DESCRIPTION" = "Forces only fullscreen capabilities within iPad apps, disallowing sharing the screen with other apps. On an external screen, the window for an app with this setting maintains its canvas size.";

diff --git a/Shared/Localizations/fr.lproj/Localizable.strings b/Shared/Localizations/fr.lproj/Localizable.strings
@@ -232,7 +232,7 @@
 "APP_SIGNING_INPUT_VIEW_CONTROLLER_REMOVE_FORCE_PRO_MOTION_DESCRIPTION" = "Enables ProMotion capabilities within the app, however on lower versions of 15.x this may not be enough.";
 
 "APP_SIGNING_INPUT_VIEW_CONTROLLER_REMOVE_FORCE_GAME_MODE" = "Force Game Mode";
-"APP_SIGNING_INPUT_VIEW_CONTROLLER_REMOVE_FORCE_PRO_MOTION_DESCRIPTION" = "Enables Game Mode within the app, minimizing background activity and prioritized performance for the app.";
+"APP_SIGNING_INPUT_VIEW_CONTROLLER_REMOVE_FORCE_GAME_MODE_DESCRIPTION" = "Enables Game Mode within the app, minimizing background activity and prioritized performance for the app.";
 
 "APP_SIGNING_INPUT_VIEW_CONTROLLER_REMOVE_FORCE_FULLSCREEN" = "Force Fullscreen";
 "APP_SIGNING_INPUT_VIEW_CONTROLLER_REMOVE_FORCE_FULLSCREEN_DESCRIPTION" = "Forces only fullscreen capabilities within iPad apps, disallowing sharing the screen with other apps. On an external screen, the window for an app with this setting maintains its canvas size.";

diff --git a/Shared/Localizations/ru.lproj/Localizable.strings b/Shared/Localizations/ru.lproj/Localizable.strings
@@ -235,7 +235,7 @@
 "APP_SIGNING_INPUT_VIEW_CONTROLLER_REMOVE_FORCE_PRO_MOTION_DESCRIPTION" = "Включает возможности ProMotion в приложении, однако на более низких версиях 15.x этого может быть недостаточно.";
 
 "APP_SIGNING_INPUT_VIEW_CONTROLLER_REMOVE_FORCE_GAME_MODE" = "Force Game Mode";
-"APP_SIGNING_INPUT_VIEW_CONTROLLER_REMOVE_FORCE_PRO_MOTION_DESCRIPTION" = "Enables Game Mode within the app, minimizing background activity and prioritized performance for the app.";
+"APP_SIGNING_INPUT_VIEW_CONTROLLER_REMOVE_FORCE_GAME_MODE_DESCRIPTION" = "Enables Game Mode within the app, minimizing background activity and prioritized performance for the app.";
 
 "APP_SIGNING_INPUT_VIEW_CONTROLLER_REMOVE_FORCE_FULLSCREEN" = "Принудить полноэкранный режим";
 "APP_SIGNING_INPUT_VIEW_CONTROLLER_REMOVE_FORCE_FULLSCREEN_DESCRIPTION" = "Принудительно включает только полноэкранные возможности в приложениях для iPad, запрещая совместное использование экрана с другими приложениями. На внешнем экране окно приложения с этой настройкой сохраняет свой размер холста.";

diff --git a/Shared/Localizations/zh.lproj/Localizable.strings b/Shared/Localizations/zh.lproj/Localizable.strings
@@ -232,7 +232,7 @@
 "APP_SIGNING_INPUT_VIEW_CONTROLLER_REMOVE_FORCE_PRO_MOTION_DESCRIPTION" = "在应用程序中启用 ProMotion 功能，但在 15.x 的较低版本上可能还不够。";
 
 "APP_SIGNING_INPUT_VIEW_CONTROLLER_REMOVE_FORCE_GAME_MODE" = "Force Game Mode";
-"APP_SIGNING_INPUT_VIEW_CONTROLLER_REMOVE_FORCE_PRO_MOTION_DESCRIPTION" = "Enables Game Mode within the app, minimizing background activity and prioritized performance for the app.";
+"APP_SIGNING_INPUT_VIEW_CONTROLLER_REMOVE_FORCE_GAME_MODE_DESCRIPTION" = "Enables Game Mode within the app, minimizing background activity and prioritized performance for the app.";
 
 "APP_SIGNING_INPUT_VIEW_CONTROLLER_REMOVE_FORCE_FULLSCREEN" = "强制全屏";
 "APP_SIGNING_INPUT_VIEW_CONTROLLER_REMOVE_FORCE_FULLSCREEN_DESCRIPTION" = "仅在 iPad 应用程序中启用全屏功能，不允许与其他应用程序共享屏幕。在外部屏幕上，启用此设置的应用程序窗口将保持画布大小。";

diff --git a/iOS/Views/Signing/SigningOptionsViewController/Identifier/IdentifiersViewController.swift b/iOS/Views/Signing/SigningOptionsViewController/Identifier/IdentifiersViewController.swift
@@ -99,6 +99,7 @@ class IdentifiersViewController: UITableViewController {
 			let key = signingDataWrapper.signingOptions.displayNameConfig.keys.sorted()[index]
 			signingDataWrapper.signingOptions.displayNameConfig.removeValue(forKey: key)
 		}
+		NotificationCenter.default.post(name: Notification.Name("saveOptions"), object: nil)
 		tableView.reloadData()
 	}
 
@@ -113,6 +114,7 @@ class IdentifiersViewController: UITableViewController {
 			case .none:
 				break
 			}
+			NotificationCenter.default.post(name: Notification.Name("saveOptions"), object: nil)
 			self?.tableView.reloadData()
 		}
 		navigationController?.pushViewController(addVC, animated: true)

diff --git a/iOS/Views/Signing/SigningOptionsViewController/SigningsOptionViewController.swift b/iOS/Views/Signing/SigningOptionsViewController/SigningsOptionViewController.swift
@@ -43,7 +43,7 @@ func toggleOptions(signingDataWrapper: SigningDataWrapper) -> [TogglesOption] {
 		),
 		TogglesOption(
 			title: String.localized("APP_SIGNING_INPUT_VIEW_CONTROLLER_REMOVE_FORCE_GAME_MODE"),
-			footer: String.localized("APP_SIGNING_INPUT_VIEW_CONTROLLER_REMOVE_FORCE_PRO_MOTION_DESCRIPTION"),
+			footer: String.localized("APP_SIGNING_INPUT_VIEW_CONTROLLER_REMOVE_FORCE_GAME_MODE_DESCRIPTION"),
 			binding: signingDataWrapper.signingOptions.forceGameMode
 		),
 		TogglesOption(
@@ -88,6 +88,20 @@ class SigningsOptionViewController: UITableViewController {
 		self.appsViewController = appsViewController
 		self.toggleOptions = feather.toggleOptions(signingDataWrapper: signingDataWrapper)
 		super.init(style: .insetGrouped)
+
+		NotificationCenter.default.addObserver(self, selector: #selector(save), name: Notification.Name("saveOptions"), object: nil)
+	}
+
+	deinit {
+		NotificationCenter.default.removeObserver(self, name: Notification.Name("saveOptions"), object: nil)
+	}
+
+	@objc func save() {
+		self.saveOptions()
+	}
+
+	func saveOptions() {
+		UserDefaults.standard.signingOptions = signingDataWrapper.signingOptions
 	}
 
 	required init?(coder: NSCoder) {
@@ -175,7 +189,7 @@ class SigningsOptionViewController: UITableViewController {
 			break
 		}
 
-		UserDefaults.standard.signingOptions = signingDataWrapper.signingOptions
+		saveOptions()
 	}
 }