[MBL-2082] Add info alert flag type #2678
Merged
+32
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifosli
requested review from
a team,
amy-at-kickstarter and
stevestreza-ksr
and removed request for
a team and
stevestreza-ksr
amy-at-kickstarter
approved these changes
Jan 5, 2026
|
|
||
| var image: Image { | ||
| switch self.alert.icon { | ||
| private func image(icon: PPOProjectCardModel.Alert.AlertIcon) -> Image { |
Contributor
There was a problem hiding this comment.
Nit: this would read slightly cleaner to me if it was image(forIcon icon:)
Contributor
Author
There was a problem hiding this comment.
I'm fine with that; updated!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Add the info alert flag type. This also updates the alert flag icon to be optional.
👀 See
Jira
✅ Acceptance criteria