Skip to content

Relaxed Cross-Origin Permissions For Draw Tool #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Relaxed Cross-Origin Permissions For Draw Tool #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
99d53db
Adding options to addImg so CORS policy will be relaxed
sol-kiddom Jul 26, 2021
e4de470
Updating addImg def for ts
sol-kiddom Jul 26, 2021
663d55f
Typos
sol-kiddom Jul 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/main.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,15 +630,15 @@ class SketchFieldDemo extends React.Component {
<Button
variant="outlined"
onClick={(e) => {
this._sketch.addImg(this.state.imageUrl)
this._sketch.addImg(this.state.imageUrl, { crossOrigin: '*' })
}}>
Load Image from URL
</Button>
</div>
<br/>
<Button
variant="outlined"
onClick={(e) => this._sketch.addImg(dataUrl)}>
onClick={(e) => this._sketch.addImg(dataUrl, { crossOrigin: '*' })}>
Load Image from Data URL
</Button>
</CardContent>
Expand Down
2 changes: 1 addition & 1 deletion types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ declare module '@kiddom/react-sketch' {
* scale: <Number: initial scale of image>
* }
*/
addImg(dataUrl: string, options?: { left?: number, top?: number, scale?: number }): void
addImg(dataUrl: string, options?: { left?: number, top?: number, scale?: number, crossOrigin?: string }): void

/**
* Zoom the drawing by the factor specified
Expand Down