[2.0.x] Revised purgeCancelledJob workaround as it's fixed in drools 9.106.0 - #218
Merged
Merged
Conversation
tkobayas
commented
Aug 28, 2026
tkobayas
commented
Collaborator
- DROOLS_PURGE_CANCELLED_JOB_EVENT_COUNT_THRESHOLD env var can still be used. Default is 100
- DROOLS_PURGE_CANCELLED_JOB_EVENT_COUNT_THRESHOLD env var can still be used. Default is 100
Contributor
There was a problem hiding this comment.
Pull request overview
Updates cancelled pseudo-clock job purging for Drools 9.106.0.
Changes:
- Replaces the reflection workaround with Drools configuration.
- Retains the environment-variable override.
- Raises HA memory-test thresholds.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
RulesExecutorSession.java |
Configures Drools and removes manual purging. |
AbstractRulesEvaluator.java |
Removes obsolete purge invocation. |
HAIntegrationMemoryLeakTest.java |
Adjusts acceptable memory overhead. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- non-numeric, negative number check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.